Invitations dialog broken - de-xbl calendar-invitations-richlistitem binding
Categories
(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)
Tracking
(Not tracked)
People
(Reporter: darktrojan, Assigned: arshad)
References
Details
(Keywords: regression)
Attachments
(3 files, 10 obsolete files)
The list in the invitations dialog (calendar-invitations-dialog.xul) is messed up, probably because richlist
only deals with richlistitem
s these days and our items are calendar-invitations-richlistitem
s.
Comment 1•6 years ago
|
||
I would assume due to bug 1523600.
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #0)
Created attachment 9053119 [details]
Screenshot from 2019-03-24 21-36-19.pngThe list in the invitations dialog (calendar-invitations-dialog.xul) is messed up, probably because
richlist
only deals withrichlistitem
s these days and our items arecalendar-invitations-richlistitem
s.
Could you please tell what should the cal-invitaiton dialog look like and what's the differnce that you see? This ll help me alot. Please post some screenshots to show that.
Comment 4•6 years ago
|
||
There is a screenshot here, the "No unconfirmed invitations" should not be at that spot (or be there at all).
Comment 5•6 years ago
|
||
Additional screenshot. The one item isn't showing for me (but there is one, as indicated in the title too)
Converting calendar-invitations-richlistitem to <richlistitem is="calendar-invitations-richlistitem"> should help.
Assignee | ||
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
On pushing a try, I got -
remote: ************************** ERROR **************************** remote: try-comm-central is CLOSED! Reason: Bug 1548973 remote: To push despite the closed tree, include "CLOSED TREE" in your push comment remote: *************************************************************
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
When do you get that? mach build doesn't complain to me
Assignee | ||
Comment 15•5 years ago
|
||
Richard, You have worked with ftl file, what's going wrong here? I get Request for keys failed because no resource bundles got generated.
error when I try get a value from the .ftl file.
Comment 16•5 years ago
|
||
You need to declare the FTL file in the XUL. Something like:
<linkset>
<html:link rel="localization" href="calendar/calendarInvitationsDialog.ftl"/>
</linkset>
Maybe the path needs some tweaks. I've never used Fluent with a extension.
Comment 17•5 years ago
|
||
Since it's done all programmatically here I don't think the link in the xul file is necessary. It works if I reference a ftl file from mail.
Something's wrong with the path though.
In jar.mn it should probably be
[localization] @AB_CD@.jar:
calendar (%calendar/**/*.ftl)
... and not calendar-@AB_CD@.jar
With that change, the calendarInvitationsDialog.ftl ends up under extensions in
{lightning-id}
- localization
- en-US (not calendar-en-US)
- calendar
- en-US (not calendar-en-US)
The thunderbird main files are under /localization.
Philipp, any ideas?
Comment 18•5 years ago
|
||
Maybe something like href="moz-extension://e2fda1a4-762b-4020-b5ad-a41df1933103/localization/calendar-@AB_CD@/calendar/calendarInvitationsDialog.ftl" or href="moz-extension://e2fda1a4-762b-4020-b5ad-a41df1933103/localization/calendar-en-US/calendar/calendarInvitationsDialog.ftl" works.
If not, maybe you need to switch to properties as the merge is next week and then the localization is frozen.
Assignee | ||
Comment 19•5 years ago
|
||
You can use this one with the properties file if ftl file issue doesn't get fixed soon.
Assignee | ||
Comment 20•5 years ago
|
||
Reporter | ||
Comment 21•5 years ago
|
||
I think it would be better if we kept Fluent out of Lightning until after 68, especially if it's just one file.
Comment 22•5 years ago
|
||
Assignee | ||
Comment 23•5 years ago
|
||
Assignee | ||
Comment 24•5 years ago
|
||
Updated•5 years ago
|
Comment 25•5 years ago
|
||
You don't need to necessarily use pluralform. Can also use bundle.formatStringFromName.
The point was that building the final string by + is basically wrong.
Updated•5 years ago
|
Comment 26•5 years ago
|
||
For where to put ftl files, calendar-ab-cd is ok. You need to possibly register the custom context, I did this some time back but can't find the code now. If it works in mail maybe check how it is registered there.
https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.html
Assignee | ||
Comment 27•5 years ago
|
||
Assignee | ||
Comment 28•5 years ago
|
||
Assignee | ||
Comment 29•5 years ago
|
||
Assignee | ||
Comment 30•5 years ago
|
||
Comment 31•5 years ago
|
||
Comment 32•5 years ago
|
||
Formatting all the strings that need formatting.
Updated•5 years ago
|
Comment 33•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ed4e2f863976
de-xbl calendar-invitations-richlistitem binding. r=mkmelin
Updated•5 years ago
|
Description
•