Enforce new character counts:

Based on a conversation with Wolasi and Nick, we've decided to keep line clamping but remove truncation and character counts.

[Tracking Requested - why for this release]: uplift will be requested for Pocket + New Tab experiments

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/78f5cee77fa8eabce6062d5be9cfc5d98594820c
removing truncation (#4751)

https://hg.mozilla.org/mozilla-central/rev/a4a56d03930a

Comment on attachment 9040508 [details]
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4751

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1524321

User impact if declined

Text may truncate in unexpected ways, showing ellipses in some instances.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

1. Open about:config
2. Change browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
3. Open a new tab
4. Confirm that no ellipses are visible in text

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Function for truncation is being removed and all references are also being removed. Code is being simplified.

String changes made/needed

Hello,

I have reproduced this issue with 67.0a1(BuildID:20190131214909)on Windows 10x64

Ellipses are no longer present latest FF Nightly (BuildID:20190212095015)

Disregard the NI Request.

Aryx, can you please uplift this?

The uplift request should have been on a phabricator attachment instead of the github PR. I'm not sure which phabricator attachment is wanted and which is obsolete, but both don't have a r+.

No Phabricator patch has an r+ - blocked by this.

Kate and/or Ed will be picking up the Phabricator patch.

The patch is updated and reviewed

Ah, I wondered why I couldn't see it in Phabricator. Thanks!

I just updated the patch again, this is actually also dependent on Bug 1520258.

https://hg.mozilla.org/releases/mozilla-beta/rev/6ce3886d5cc5

I have re-verified this issue again in the 66.0b8(BuildID: 20190214102000 Build from taskcluster) on Win 10x64. Ubuntu 16.04 and macOS 10.12. Confirming this as verified fixed.