Spoc frequency cap via visibility
Categories
(Firefox :: New Tab Page, defect, P2)
Tracking
()
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
We need to show spocs only for a certain number of times. Probably from a server defined value.
We might also have multiple spocs or spocs showing below the fold.
This might be helpful: https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API in seeing if an element is visible or not.
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Comment 3•6 years ago
|
||
[Tracking Requested - why for this release]: this will be uplifted into Pocket NT for 66 experiments
Comment 4•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Verified, what I did was to verify was:
- Set the pref
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Make sure the pref
browser.newtabpage.activity-stream.discoverystream.spoc.impressions
is reset. - Load a new tab.
- Scroll down new tab, and check the pref
browser.newtabpage.activity-stream.discoverystream.spoc.impressions
for changes.
expected: It should add timestamps to that pref inside an id, as you scroll down the new tab, new spocs should come into view, and when that happens, a new impression should be added to browser.newtabpage.activity-stream.discoverystream.spoc.impressions
If you keep doing this, (or refreshing new tab with a spoc in view) eventually you'll stop seeing cards that say "sponsored by ..."
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9043395 [details]
Bug 1520258 - Adding spoc frequency caps based on visibility
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
We will not be able to cap sponsored content ("SPOCs") to a maximum number of impressions during the Pocket experiment, thus making it very difficult to get valid/comparable data to existing implementations and our expectations of sponsored content performance. This is critical for Pocket's 2019 revenue goals.
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
Yes
If yes, steps to reproduce
See https://bugzilla.mozilla.org/show_bug.cgi?id=1520258#c6. The team is also working on a holistic test plan covering sponsored content and caching for end of day Feb 15th.
List of other uplifts needed
None
Risk to taking this patch
Medium
Why is the change risky/not risky? (and alternatives if risky)
There is a significant amount of functionality being added here, but it is considered critical enough for product to accept the risk.
The risk is mitigated by: isolating the implementation from production code; doing additional manual QA.
String changes made/needed
None
Comment on attachment 9043395 [details]
Bug 1520258 - Adding spoc frequency caps based on visibility
Planned uplift for Activity Stream, adds tests, verified in Nightly.
OK for uplift for beta 8.
Sounds like this should land first, then the work in bug 1524321.
Comment 11•6 years ago
|
||
bugherder uplift |
Comment 12•6 years ago
|
||
I have verified that the issue is no longer reproducible on the latest Beta 66.0b8 (Build ID 20190214195736) and on the latest Nightly 67.0a1 (Build ID 20190215014208) on Windows 10 x64, Mac 10.14, and Arch Linux 4.14.3.
Updated•5 years ago
|
Description
•