Move build/autoconf/arch.m4 to python configure
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•6 years ago
|
||
It hasn't needed it since bug 1397776.
|
|
Assignee | |
Comment 2•6 years ago
|
||
The file is essentially limited to ARM flag tweaks, so we make the
corresponding python configure code ARM-only. In large parts, the
python code sets things up similarly, although in a few places we try to
be smarter about than the current autoconf-based code.
The resulting config.status have been verified to only have
insignificant differences on both arm and aarch64 android builds.
Depends on D24000
|
||
Comment 4•6 years ago
|
||
Backed out for build bustages
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7947b90f15808c0de5673831950fe2886558d23c&selectedJob=234877660
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234877660&repo=autoland&lineNumber=39973
Backout: https://hg.mozilla.org/integration/autoland/rev/fece5bb7e809fd3a7dd960ad9c0df9167b27fecc
|
|
Assignee | |
Comment 5•6 years ago
|
||
Fun times. This didn't fail when I ran the lint locally... but that was before I added the when on the include('arm.configure')... and sure enough, I can reproduce locally now, and if I remove the when, I'm back to the lint passing. It was kind of unexpected, actually, that the lint passed in the first place. I was happy that it did, because that avoided having to figure out a way around the lint... but I guess I'll have to figure it out in the end.
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/22c1c1ddce35
https://hg.mozilla.org/mozilla-central/rev/afac9aaedb23
Description
•