Design refinements for 66 components
Categories
(Firefox :: New Tab Page, defect, P2)
Tracking
()
People
(Reporter: k88hudson, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(3 files)
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 7•6 years ago
|
||
Design refinements required for the Pocket experiment include the following [from Wolasi]:
- Change color of "Sponsored by…" on SpoC label to units to #737373
- Change font-size to 14px for the following classes…
.ds-list:not(.ds-list-full-width) .ds-list-item-title
.ds-hero .ds-card .meta .title
.ds-column-9 .ds-card-grid .meta .title, .ds-column-10 .ds-card-grid .meta .title, .ds-column-11 .ds-card-grid .meta .title, .ds-column-12 .ds-card-grid .meta .title
.ds-hero .wrapper .meta p
.ds-card .meta .excerpt
.ds-list-item .ds-list-item-excerpt
.ds-navigation
- Make the following margin and padding changes for the indicated classes:
.ds-hero .wrapper {
margin: 12px 0 16px;
padding: 16px 0;
}
.ds-hero-no-border .wrapper {
padding: 0 0 8px 0;
}
Please make the following changes/additions for the indicated classes
.ds-hero .wrapper .meta header
margin-bottom: 4px
line-height: 28px
.ds-header
margin: 12px 0;
.ds-list-item .ds-list-item-title
margin-bottom: 4px
.ds-list-item .ds-list-item-excerpt
margin-bottom: 4px
.ds-card p
margin: 4px 0 0 0
Make this addition to the section-title class
.ds-section-title {
margin-top: 24px;
}
Please make the following change to the component header class
.ds-header {
margin: 24px 0 12px;
}
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Doesn't require further QA.
Reporter | ||
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Comment on attachment 9042549 [details]
Bug 1524632 - Design tweaks for discovery stream
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
Less optimal visual layout for Discovery Stream
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
No
Needs manual test from QE?
Yes
If yes, steps to reproduce
- Open
about:config
- Change
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Open a new tab
- Confirm that layout doesn't look broken
List of other uplifts needed
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
CSS only patch aside from 1 minor HTML tweak (class name added, truncation removed on content-src/components/DiscoveryStreamComponents/Hero/Hero.jsx
)
String changes made/needed
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 13•6 years ago
|
||
Updated•6 years ago
|
Comment 14•6 years ago
|
||
Hello,
Verified fixed with the latest FF Nightly build 67.0a1 (buildID :20190212095015) on Win 10x64 and macOS 10.11.
Can confirm that the layout is not broken.
Comment on attachment 9042549 [details]
Bug 1524632 - Design tweaks for discovery stream
Verified in nightly, part of planned uplifts for Activity Stream experiments in 66.
Comment 16•6 years ago
|
||
I tried to uplift this, however got conflicts:
warning: conflicts while merging browser/components/newtab/common/PrerenderData.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/content-src/components/DiscoveryStreamComponents/DSCard/DSCard.jsx! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/content-src/components/DiscoveryStreamComponents/Hero/Hero.jsx! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/content-src/components/DiscoveryStreamComponents/List/List.jsx! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/content-src/components/DiscoveryStreamComponents/SpocIntersectionObserver/SpocIntersectionObserver.jsx! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/css/activity-stream-linux.css.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/css/activity-stream-mac.css.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/css/activity-stream-windows.css.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/data/content/activity-stream.bundle.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/data/content/activity-stream.bundle.js.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/lib/ActivityStream.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/lib/DiscoveryStreamFeed.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/locales-src/mr/strings.properties! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/locales-src/sr/strings.properties! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/prerendered/locales/mr/activity-stream-prerendered-noscripts.html! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/prerendered/locales/mr/activity-stream-prerendered.html! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/prerendered/locales/sr/activity-stream-prerendered-noscripts.html! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/prerendered/locales/sr/activity-stream-prerendered.html! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/test/unit/content-src/components/DiscoveryStreamComponents/List.test.jsx! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/test/unit/lib/DiscoveryStreamFeed.test.js! (edit, then use 'hg resolve --mark')
Comment 17•6 years ago
|
||
The merge conflicts seem like the whole export commit bug 1526066 was attempted to be applied instead of just attachment 9042549 [details]
Comment 18•6 years ago
|
||
Tried to uplift it but still encountered conflicts:
merging browser/components/newtab/css/activity-stream-linux.css
merging browser/components/newtab/css/activity-stream-linux.css.map
merging browser/components/newtab/css/activity-stream-mac.css
merging browser/components/newtab/css/activity-stream-mac.css.map
merging browser/components/newtab/css/activity-stream-windows.css
merging browser/components/newtab/css/activity-stream-windows.css.map
merging browser/components/newtab/data/content/activity-stream.bundle.js
merging browser/components/newtab/data/content/activity-stream.bundle.js.map
warning: conflicts while merging browser/components/newtab/css/activity-stream-linux.css.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/css/activity-stream-mac.css.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/css/activity-stream-windows.css.map! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/newtab/data/content/activity-stream.bundle.js.map! (edit, then use 'hg resolve --mark')
Gavin Suntop, Ed Lee can you guys please take a look?
Reporter | ||
Comment 19•6 years ago
|
||
:gvn, I have fixed the patch and updated it to be dependent on Bug 1524321 (there were conflicts). Can you update the uplift to request say this depends on Bug 1524321?
Comment 21•6 years ago
|
||
Hello,
I have re-verified this issue again in the 66.0b8(BuildID: 20190214102000 from Taskcluster) on Win 10x64. Ubuntu 16.04 and macOS 10.12. Confirming this as verified fixed.
Comment 22•6 years ago
|
||
Pretty sure this hasn't been uplifted yet to mozilla-beta/66.
Comment 23•6 years ago
|
||
bugherder uplift |
Comment 24•6 years ago
|
||
Hello, re-rechecked this issue on 66.0b8(BuildID:20190214195736) with Win10x64 and macOS 10.12 . confirming this issue as verified fixed.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•