Move image loads out of the style struct accessors.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(3 files)
Last step before removing the pres context pointer from the styles.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
After this I can pass the document from the caller to
ResolveSameStructsAs, and get rid of the pres context pointer.
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a476a9dc9f824ea353985774de235d6c1095f74
Green modulo the test that needs to be changed to not do remote connections.
|
||
Comment 3•6 years ago
|
||
Backed out for build bustages.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226180389&repo=autoland&lineNumber=16971
Backout: https://hg.mozilla.org/integration/autoland/rev/954ae98c066e4f06b1f4de68dbe53034efb37aee
|
|
Assignee | |
Updated•6 years ago
|
|
|
||
Comment 4•6 years ago
|
||
Backed out for build bustages.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226201589&repo=autoland&lineNumber=18746
Backout: https://hg.mozilla.org/integration/autoland/rev/090b26946348bf5f20ee20f74343c522a56cae7b
|
|
Assignee | |
Comment 6•6 years ago
|
||
Before the other patch in this bug, list-style-image is the only image url that
made the list image request more lazily (during reflow and during
getComputedStyle).
This test was relying on the request being canceled soon enough that it didn't
crash the browser (we don't allow remote connections during tests).
I don't have a better idea than removing this test unfortunately. I've verified
that switching the test to use background-image or some other thing it makes the
request without my patch.
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d52e6ae0212c
https://hg.mozilla.org/mozilla-central/rev/6b71e3d434c2
|
||
Comment 9•6 years ago
|
||
|
||
Comment 11•6 years ago
|
||
Noticed an AWSY performance improvement! \0/
== Change summary for alert #19177 (as of Tue, 05 Feb 2019 19:21:19 GMT) ==
Improvements:
5% Images osx-10-10 opt stylo 4,474,022.09 -> 4,250,151.72
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19177
Description
•