Closed Bug 1528451 Opened 6 years ago Closed 6 years ago

incorrect styling on moneysmart.gov.au

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: heycam, Assigned: emilio)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

STR:

  1. Go to https://www.moneysmart.gov.au/investing/financial-advice/financial-advice-toolkit.
  2. Mouse over the numbered items with the purple circles.
  3. Notice that on mouse over the purple circle disappears, and after mousing out it doesn't reappear.

Expected results:

The background changes on hover and the purple circle doesn't disappear.

12:17.32 INFO: Last good revision: dfefd2d4d63f8f2cdeb57e6ee16a8c31c4f54447
12:17.32 INFO: First bad revision: 6b71e3d434c232998629b8e18a983212e9d3fc9d
12:17.32 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dfefd2d4d63f8f2cdeb57e6ee16a8c31c4f54447&tochange=6b71e3d434c232998629b8e18a983212e9d3fc9d

Looks like it's bug 1525134. Emilio, do you have time to take a look?

Blocks: 1525134
Flags: needinfo?(emilio)
Keywords: regression
Assignee: nobody → emilio
.accordion-subSection h4:not(.noCircle)::first-letter {
    color: #ffffff;
    font-size: 1.5em;
    width: 1.4em;
    overflow: auto;
    display: inline-block;
    text-align: center;
    vertical-align: middle;
    margin-right: 0.5em;
    padding: 0.2em 0.5em;
    background: url("/media/559754/circle-6d3a96.svg") 0 0 no-repeat;
    background-size: contain;

}

This is more consistent with all the other image request code, and handles
pseudo-elements properly without having to add more out-of-band calls to
UpdateStyleOfOwnedChildFrame and such.

Flags: needinfo?(emilio)
Attached file Bug 1528451 - Fix nsContinuingTextFrame::Init order. (obsolete) (deleted) —

So that the continuation pointer is setup before DidSetStyleContext runs.

I don't see any reason for not doing this, the current thing is a footgun.

Attachment #9044537 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d33544f0d8e6 Move code that starts image loads to DidSetComputedStyle. r=heycam
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15459 for changes under testing/web-platform/tests
Upstream PR was closed without merging

There was a XUL subclass that only gets images on windows, which was not calling the base class' DidSetComputedStyle function.

Flags: needinfo?(emilio)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/2bbbcf59d8f9 Move code that starts image loads to DidSetComputedStyle. r=heycam
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Regressions: 1540984
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: