Closed
Bug 1526324
Opened 6 years ago
Closed 6 years ago
Stop serializing JSScript::needsArgsObj in XDR
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
After the split of script flags into mutable and immutable, it becomes clear that needsArgsObj flag is the only mutable flag that XDRScript preserves. To simplify code and remove special cases we should remove this as no other performance hinting is preserved in XDR.
|
Assignee | |
Comment 1•6 years ago
|
||
DRScript should only be preserving ImmutableFlags for consistency.
While preserving the flag might have helped in some cases, it was a
special case of preserving performance hints and should be removed for
simplicity.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8e74c762135
Stop transcoding NeedsArgsObj flag in XDRScript r=jandem
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
|
Assignee | |
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•