Closed Bug 1528964 Opened 6 years ago Closed 6 years ago

js::CopyScript spring cleaning

Categories

(Core :: JavaScript Engine, enhancement, P1)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(8 files)

Bug 1528964 - Part 1: Absorb CreateEmptyScriptForClone into CopyScript
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 2: Split part of CopyScript into PrivateScriptData::Clone
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 3: Use createPrivateScriptData in PrivateScriptData::Clone
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 4: Add SharedScriptData::markForCrossZone
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 5: Organize CopyScript similar to XDRScript
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 6: Preserve column while cloning scripts
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 7: Don't preserve needsArgsObj flag in CopyScript
(deleted), text/x-phabricator-request
Details
Bug 1528964 - Part 8: CopyScript should directly return result script
(deleted), text/x-phabricator-request
Details

Similar to Bug 1525505, the CopyScript function needs a lot of cleanup to better match the rest of the JSScript initialization code. This is currently making it hard to do major changes around JSScript safely and efficiently.

This is a code-motion patch. Note that the order of initialization of
PrivateScriptData vs JSScript fields changes but the reordered
operations are all infallible/gc-free so this is not observable.

Depends on D20332

Also use PrivateScriptData directly instead of through the JSScript.

Depends on D20333

Depends on D20334

The JSScript fields are now initialized before the script data objects
to better align with XDRScript.

Depends on D20335

This is an older bug that was hidden in the old CopyScript
implementation.

Depends on D20336

Similar to Bug 1526324, we should avoid one-off optimizations that share
runtime data between script copies.

Depends on D20337

Follow-up work for other bugs:

  • Revisit the scope cloning logic to simplify it more
  • Minimize the three-way diff between BytecodeCompiler/XDRScript/CopyScript now that they are reasonably close
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0192ce3b15d Part 1: Absorb CreateEmptyScriptForClone into CopyScript r=jandem https://hg.mozilla.org/integration/autoland/rev/cfcd89883d1e Part 2: Split part of CopyScript into PrivateScriptData::Clone r=jandem https://hg.mozilla.org/integration/autoland/rev/05d3db762616 Part 3: Use createPrivateScriptData in PrivateScriptData::Clone r=jandem https://hg.mozilla.org/integration/autoland/rev/de9bb567ad44 Part 4: Add SharedScriptData::markForCrossZone r=jandem https://hg.mozilla.org/integration/autoland/rev/b89f5efa1bf9 Part 5: Organize CopyScript similar to XDRScript r=jandem https://hg.mozilla.org/integration/autoland/rev/f0e44d5ad172 Part 6: Preserve column while cloning scripts r=jandem https://hg.mozilla.org/integration/autoland/rev/348464a06c14 Part 7: Don't preserve needsArgsObj flag in CopyScript r=jandem https://hg.mozilla.org/integration/autoland/rev/73749ff4f2ef Part 8: CopyScript should directly return result script r=jandem
Blocks: 1535138
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: