Closed Bug 1526911 Opened 6 years ago Closed 6 years ago

Fix ResourceWarnings seen during tests

Categories

(Tree Management :: Treeherder, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Python 3 has a new warning type of ResourceWarning.

Whilst working on bug 1330474 I've seen a number of those warnings fly past. Once on Python 3 it would be good to fix them and add that warning to the types of warnings that are treated as errors in setup.cfg to prevent regressions.

So it appears we can't make these warnings fatal, but we can at least fix the ones seen when running the tests.

ResourceWarning: unclosed file <_io.TextIOWrapper name='schemas/performance-artifact.json' mode='r' encoding='UTF-8'>

Assignee: nobody → emorley
Status: NEW → ASSIGNED
Summary: Make Python 3 ResourceWarnings fatal during tests → Fix ResourceWarnings seen during tests
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: