set permission on initial upgrade to incognito feature
Categories
(WebExtensions :: General, defect, P1)
Tracking
(firefox67 verified)
Tracking | Status | |
---|---|---|
firefox67 | --- | verified |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
(Blocks 1 open bug)
Details
Attachments
(7 files, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
image/png
|
meridel
:
ui-review+
|
Details |
(deleted),
image/png
|
emanuela
:
ui-review+
|
Details |
(deleted),
video/quicktime
|
Details | |
(deleted),
image/png
|
emanuela
:
ui-review+
|
Details |
(deleted),
application/x-zip-compressed
|
Details |
Assignee | ||
Comment 1•6 years ago
|
||
When a user first upgrades to a version where incognito is enabled,
add the permission to all enabled extensions. This preserves user workflow
and addresses other issues (e.g. proxy). This will only happen once.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Text change on about:addons
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
Created attachment 9044035 [details]
private window first runhttps://bugzilla.mozilla.org/enter_bug.cgi
Looks good!
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
Question: why the message bar is sticky?
Can we unstick it? It's pretty long, and I'm afraid it will annoying to the end users who already act on it. If it's something complicated, I'm ok to track this in a separate bug.
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
(In reply to emanuela [ux] from comment #10)
Question: why the message bar is sticky?
Can we unstick it? It's pretty long, and I'm afraid it will annoying to the end users who already act on it. If it's something complicated, I'm ok to track this in a separate bug.
I'm not clear what this is about. What message bar?
Comment 13•6 years ago
|
||
The message bar it's the banner in about:addons
.
I attached a video that shows what I described in the other comment.
Assignee | ||
Comment 14•6 years ago
|
||
(In reply to emanuela [ux] from comment #13)
Created attachment 9044199 [details]
messagebar.movThe message bar it's the banner in
about:addons
.I attached a video that shows what I described in the other comment.
That is the way that block works. It could change in a followup, it will affect all usage of that block.
Comment 15•6 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #14)
(In reply to emanuela [ux] from comment #13)
Created attachment 9044199 [details]
messagebar.movThe message bar it's the banner in
about:addons
.I attached a video that shows what I described in the other comment.
That is the way that block works. It could change in a followup, it will affect all usage of that block.
I think I never noticed cos the block was never so tall. I'll create a followup bug. This small issue is not a blocker.
Assignee | ||
Comment 16•6 years ago
|
||
more padding on top of checkbox (using margin: 8px 4px 2px;)
Comment 17•6 years ago
|
||
Comment 19•6 years ago
|
||
How does this work with bug 1513344? Do we send privateBrowsingAllowed "on" as soon as the doorhanger value is set (or not set)?
Comment 20•6 years ago
|
||
(In reply to David Durst [:ddurst] from comment #19)
How does this work with bug 1513344? Do we send privateBrowsingAllowed "on" as soon as the doorhanger value is set (or not set)?
Bug 1513344 doesn't yet cover this, we filed bug 1529347 as the follow up in which we will record an additional telemetry event when a user is enabling an extension on PB windows from the install doorhanger.
Assignee | ||
Comment 21•6 years ago
|
||
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3063f37eb7b2
https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb
Comment 24•6 years ago
|
||
(In reply to Cosmin Sabou [:CosminS] from comment #23)
https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb
+<!ENTITY addonPostInstall.incognito.label "Allow this extension to run in Private Windows.">
I’m afraid this is an option, and hence should not end with a trailing period. The same may apply to addonPrivateBrowsing.learnMore.label and private-browsing-learn-more (see legacy-learn-more).
Comment 25•6 years ago
|
||
(In reply to Ton [:Tonnes] from comment #24)
(In reply to Cosmin Sabou [:CosminS] from comment #23)
https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb
+<!ENTITY addonPostInstall.incognito.label "Allow this extension to run in Private Windows.">
I’m afraid this is an option, and hence should not end with a trailing period. The same may apply to addonPrivateBrowsing.learnMore.label and private-browsing-learn-more (see legacy-learn-more).
That document shouldn't be used as point of reference for en-US copy. If such a reference can be created, it should live here and be done by the team in charge of copy
https://design.firefox.com/photon/copy/punctuation.html
Comment 26•6 years ago
|
||
(In reply to Ton [:Tonnes] from comment #24)
(In reply to Cosmin Sabou [:CosminS] from comment #23)
https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb
+<!ENTITY addonPostInstall.incognito.label "Allow this extension to run in Private Windows.">
I’m afraid this is an option
For clarity, it's a checkbox (and yes, normally they don't have a closing period).
Comment 27•6 years ago
|
||
This issue is verified as fixed on Firefox 67.0a1 (20190304215035) under Win 7 64-bit and Mac OS X 10.14.1.
After updating Nightly from an older version to the latest one, with some installed extensions, the enabled extensions are automatically granted in PB.
The post install panel is displayed, like in the Comment 17.
Please see the attached video and screenshot.
The banner from about:addons is permanently displayed while scrolling, this issue will be tracked in a separate bug.
Assignee | ||
Comment 28•6 years ago
|
||
(In reply to Ton [:Tonnes] from comment #24)
The same may apply to addonPrivateBrowsing.learnMore.label and private-browsing-learn-more (see legacy-learn-more).
Given it's a complete sentence, not on an option, I think the period is appropriate. I'll let Flod & Meridel decide.
See attachment 9044034 [details] and attachment 9044035 [details].
Comment 30•6 years ago
|
||
No period at the end of the link. Following patterns established in other parts of the product, including new Private Windows new tab.
Assignee | ||
Updated•5 years ago
|
Description
•