Remove the closing period in the "Allow this extension to run in Private Windows." string
Categories
(WebExtensions :: General, enhancement, P1)
Tracking
(firefox67 verified)
Tracking | Status | |
---|---|---|
firefox67 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: mixedpuppy)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
See bug 1527127 comment 26.
This string represents a checkbox, and should not have a trailing period.
https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#1136
Comment 1•5 years ago
|
||
Meridel, not sure if you did the copy for this feature, can you double check (or redirect)?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
Is this the post install door hanger? No period after string. Also no period after "Learn more"—if we have one there (I don't see a visual here).
Assignee | ||
Comment 4•5 years ago
|
||
There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].
Comment 5•5 years ago
|
||
Aha, thank you. The plan was to include a link to the SUMO article in this panel. Not possible?
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/364ed778d761 remove period from checkbox description r=flod,mstriemer
Assignee | ||
Comment 7•5 years ago
|
||
(In reply to Meridel from comment #5)
Aha, thank you. The plan was to include a link to the SUMO article in this panel. Not possible?
We discussed it, getting the right alignments with xul/dtd had issues. We'll add it in the future.
Comment 8•5 years ago
|
||
Sounds good, thank you.
Comment 9•5 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].
However, both "Learn how to manage extension settings" text links in addonPrivateBrowsing.learnMore.label and private-browsing-learn-more could be considered to take along (see bug 1527127 comment 24 and the other attachments).
Assignee | ||
Comment 10•5 years ago
|
||
(In reply to Ton [:Tonnes] from comment #9)
(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].
However, both "Learn how to manage extension settings" text links in addonPrivateBrowsing.learnMore.label and private-browsing-learn-more could be considered to take along (see bug 1527127 comment 24 and the other attachments).
That should have been a new bug, not a comment on a bug. It got missed.
Comment 11•5 years ago
|
||
bugherder |
Comment 12•5 years ago
|
||
This issue is verified as fixed on Firefox 67.0a1 (20190312095443) under Win 7 64-bit and Mac OS X 10.14.1.
Please see the attached screenshot.
Description
•