Please make the following changes for Cards and Lists

• The height of items in row should match the height of the tallest item in the row
• The context for SPOC items and source should be bottom aligned
• For lists items without excerpts the space between the title and the source (and context for SPOCs should be 4px
• For cards and list items with excerpts, the minimum spacing between the excerpt and the source (and context for SPOCs should be 8px
• For lists change square image width and height to 80px

Figma Spec Links

• Cards -> https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=12%3A91
• Lists -> https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=10%3A94

Looks like bug 1519879 regressed this for cards although lists never had source bottom aligned.

QA steps:

1. use dev-test-all (about:config set browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=dev-test-all"})
2. open a new tab and make sure all source domain text is at the bottom left corner of each item
3. also check list images are 80px tall

https://hg.mozilla.org/mozilla-central/rev/1cfd69d05aa1

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (67.0a1 Build ID - 20190217214556) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the source domain text is displayed in the left corner of each item and the check list images are 80px tall.

Comment on attachment 9044384 [details]
Bug 1527437 - [Cards][Lists] Align spocs items to bottom of container

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1512725

User impact if declined

User facing bug, user experience is affected

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

QA done

List of other uplifts needed

Bug 1527702

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Small change that has already been tested

String changes made/needed

Comment on attachment 9044384 [details]
Bug 1527437 - [Cards][Lists] Align spocs items to bottom of container

OK for uplift for beta 10, mostly css fixes, verified in nightly.

https://hg.mozilla.org/releases/mozilla-beta/rev/c5b7791033e0

(In reply to Marius Coman [:mcoman], Experiments QA from comment #7)

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (67.0a1 Build ID - 20190217214556)

Could you please verify this issue on an early 66.0b10 build:

Windows 64: https://queue.taskcluster.net/v1/task/enVix5uvRveeQnNfxxl5mQ/runs/0/artifacts/public/build/target.zip
OS X: https://queue.taskcluster.net/v1/task/BbyPjtloRuCbHM2gX_9Hlw/runs/0/artifacts/public/build/target.dmg
Linux 64: https://queue.taskcluster.net/v1/task/CTU-aOfCSZe2B2tBVk_1GQ/runs/0/artifacts/public/build/target.tar.bz2

Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&searchStr=64-n%2C%28n%29&revision=c5b7791033e051902646cf52f0bfd6946c5a1704

I have verified this issue with the latest Firefox Beta (66.0b10 Build ID - 20190219202808) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the source domain text is displayed in the left corner of each item and the check list images are 80px tall.