ensure spoc items work in ds lists
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
People
(Reporter: dmosedale, Assigned: pdahiya)
References
Details
(Keywords: github-merged)
Attachments
(3 files)
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
(deleted),
image/png
|
Details |
This may just be QA verification, or it may also involve a bit of code. It should also work on double-wide list items, if those are implemented by the time this is done.
Comment 1•6 years ago
|
||
I dunno if this is needed for MVP, but I do think it's something on Nick's mind.
Updated•6 years ago
|
Comment 2•6 years ago
|
||
This might be easier now than I initially predicted, it might just work if the server were to pass spoc probability and position info into the component via the layout. Super low hanging fruit here, with pretty high gains.
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 3•6 years ago
|
||
Nick, is there a clear decision on SPOCs in the MVP for 66 for lists?
Comment 4•6 years ago
|
||
[Tracking Requested - why for this release]:
Comment 5•6 years ago
|
||
Here's a link to the Figma spec for SPOCs
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=585%3A1
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
How to test:
- go to about:config
- search for discoverystream.config and set preference to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}
- Open new tab and search for 'sponsored' text in list items and verify spoc items show up in list.
Assignee | ||
Comment 9•6 years ago
|
||
NI Brahmini to help QA the fix. Thanks!
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
QA Results : Pass
Tested on :
FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro
Observations :
- With the pref, I'm seeing 3 spoc items.
Results attached : QA Results : bug - 1519879.png
Closing as verified.
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Can you fill out the uplift request form for this?
Assignee | ||
Comment 13•6 years ago
|
||
Comment on attachment 9043732 [details]
Bug 1519879 - Spoc Items in List
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
Required to display sponsored content in List layout for Pocket New Tab experiments
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
Yes
If yes, steps to reproduce
- go to about:config
- Search for discoverystream.config and set preference to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}
- Open new tab and search for 'sponsored' text in list items and verify spoc items show up in list.
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
UI changes touching List component for pocket new tab experiment that's not turned on by default in beta
String changes made/needed
None
Comment on attachment 9043732 [details]
Bug 1519879 - Spoc Items in List
Planned work for pocket/new tab.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.
Comment 15•6 years ago
|
||
bugherder uplift |
Comment 16•6 years ago
|
||
(In reply to Brahmini Nagabandi from comment #11)
Created attachment 9044061 [details]
QA Results : bug - 1519879.pngQA Results : Pass
Tested on :
FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 ProObservations :
- With the pref, I'm seeing 3 spoc items.
Results attached :
QA Results : bug - 1519879.png
Closing as verified.
Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?
Updated•6 years ago
|
Comment 17•6 years ago
|
||
Not sure if this was accidentally marked verified. There was no accompanying verification comment.
Comment 18•5 years ago
|
||
BETA Testing:
QA Results : Pass
*Tested on *
FF Beta version : 66.0b9 (64-bit)
OS : Mac and Windows 10 Pro
Date : Feb 21
Observations :
- Using pref
discoverystream.config
set to{"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}
I'm seeing 3 spoc items. Works as expected.
Verified.
Updated•5 years ago
|
Comment 19•5 years ago
|
||
(In reply to Brahmini Nagabandi from comment #18)
BETA Testing:
QA Results : Pass
*Tested on *
FF Beta version : 66.0b9 (64-bit)
OS : Mac and Windows 10 ProDate : Feb 21
Observations :
- Using pref
discoverystream.config
set to
{"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist. githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/ 7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}
I'm seeing 3 spoc items. Works as expected.
Verified.
Thanks for verifying this!
Updated•5 years ago
|
Description
•