We should always decommit memory when doing a shrinking GC
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This condition can be true even if we're doing shrinking GCs:
Fixing this wins at least 4 MB on AWSY's JS Opt number.
|
Assignee | |
Comment 1•6 years ago
|
||
This wins at least 4 MB on AWSY's JS Opt number because we could have a lot of
unused arenas.
|
||
Updated•6 years ago
|
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90ac938bc5a3 Don't skip decommitting memory when we are doing a shrinking GC. r=sfink
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
|
||
Comment 4•6 years ago
|
||
Noticed some AWSY improvements! \0/
Part of them can also be attributed to bug 1433007.
== Change summary for alert #19385 (as of Fri, 15 Feb 2019 01:17:29 GMT) ==
Improvements:
6% JS windows10-64 pgo stylo 114,532,852.70 -> 108,228,275.58
3% Explicit Memory windows10-64 pgo stylo 327,603,748.07 -> 318,870,647.75
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19385
|
||
Comment 5•6 years ago
|
||
== Change summary for alert #19564 (as of Fri, 22 Feb 2019 06:32:34 GMT) ==
Improvements:
5% JS linux64-stylo-sequential opt stylo-sequential 113,904,145.01 -> 108,580,789.31
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19564
Description
•