Closed Bug 1529334 Opened 6 years ago Closed 6 years ago

Blocking/unblocking CFR doesn't clear impressions

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Iteration:
67.2 - Feb 11 - 24
Tracking Status
firefox67 --- fixed

People

(Reporter: k88hudson, Assigned: andreio)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

I noticed that when blocking CFR and unblocking via the about:newtab#devtools page, I was no longer able to clear impressions. This didn't use the be the case and makes it difficult to debug without throwing out the profile.

Priority: -- → P1
Assignee: nobody → andrei.br92

I'm not able to reproduce this. Turned CFR off via ASR debug page, turned it back on and impressions are back to 0.
Can you please double check?

Flags: needinfo?(khudson)

STR is:

  1. Open ASR devtools, click show a few times on a CFR. Impressions should increment.
  2. Block the message. Unblock the message. Impressions says 0.
  3. Restart the browser. Check ASR devtools again

Expected: Impressions should still be 0 for that message.
Actual: Impressions says the old number before blocking/unblocking.

Flags: needinfo?(khudson)

Weirdly enough if I add more impressions after unblocking, those impressions persist (i.e. if I had 6, and then block/unblock, do another 2, then restart, indexedDB still has 2 impressions)

Keywords: github-merged
Keywords: github-merged
Blocks: 1529755
Iteration: --- → 67.2 - Feb 11 - 24
Keywords: github-merged
Target Milestone: --- → Firefox 67
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: