Closed
Bug 1529334
Opened 6 years ago
Closed 6 years ago
Blocking/unblocking CFR doesn't clear impressions
Categories
(Firefox :: Messaging System, defect, P1)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: k88hudson, Assigned: andreio)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
I noticed that when blocking CFR and unblocking via the about:newtab#devtools page, I was no longer able to clear impressions. This didn't use the be the case and makes it difficult to debug without throwing out the profile.
Reporter | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → andrei.br92
Assignee | ||
Comment 1•6 years ago
|
||
I'm not able to reproduce this. Turned CFR off via ASR debug page, turned it back on and impressions are back to 0.
Can you please double check?
Flags: needinfo?(khudson)
Reporter | ||
Comment 2•6 years ago
|
||
STR is:
- Open ASR devtools, click show a few times on a CFR. Impressions should increment.
- Block the message. Unblock the message. Impressions says 0.
- Restart the browser. Check ASR devtools again
Expected: Impressions should still be 0 for that message.
Actual: Impressions says the old number before blocking/unblocking.
Flags: needinfo?(khudson)
Reporter | ||
Comment 3•6 years ago
|
||
Weirdly enough if I add more impressions after unblocking, those impressions persist (i.e. if I had 6, and then block/unblock, do another 2, then restart, indexedDB still has 2 impressions)
Comment 4•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Keywords: github-merged
Reporter | ||
Updated•6 years ago
|
Keywords: github-merged
Comment 5•6 years ago
|
||
Iteration: --- → 67.2 - Feb 11 - 24
status-firefox67:
--- → fixed
Keywords: github-merged
Target Milestone: --- → Firefox 67
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•