Closed Bug 1529345 Opened 6 years ago Closed 5 years ago

Implement Gecko event breakpoint notification infrastructure and expose via IDL interface

Tracking

(firefox69 fixed)

Status:

RESOLVED FIXED

Milestone:

Firefox 69

Tracking Flags:

Tracking

Status

firefox69

---

fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

Details

(Whiteboard: [debugger-mvp])

Attachments

(2 files)

Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1529345 - Part 1: Handle some missing includes. 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details

Logan Smyth [:loganfsmyth]

Assignee

Description

•

6 years ago

We want a JS API to allow the debugger server to register a callback that will be called just before and just after Gecko dispatches a DOM event.

The plan at the moment is an API like

ChromeUtils.getDebuggerNotifier(globalObj).addDOMEventListener((evt, preOrPost) => {

});

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

6 years ago

Priority: P1 → P2

Marco Mucci [:MarcoM]

Updated

•

5 years ago

Whiteboard: [debugger-mvp]

Logan Smyth [:loganfsmyth]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. (deleted) — Details

Boris Zbarsky [:bzbarsky]

Comment 2

•

5 years ago

Can we find a better place for this to live than dom/base? Was a new subdirectory considered?

Logan Smyth [:loganfsmyth]

Assignee

Comment 3

•

5 years ago

@bz Absolutely. That was one of my outstanding questions on this. I'd be 100% for putting these in a subdirectory. Would dom/debugger be reasonable?

Boris Zbarsky [:bzbarsky]

Comment 4

•

5 years ago

Works for me. Peter, any objections?

Flags: needinfo?(peterv)

Logan Smyth [:loganfsmyth]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1529345 - Part 1: Handle some missing includes. (deleted) — Details

Phabricator Automation

Updated

•

5 years ago

Attachment #9063906 - Attachment description: Bug 1529345 - Add Gecko infrastructure for receiving notifications about debugger-related events. → Bug 1529345 - Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events.

Peter Van der Beken [:peterv]

Comment 6

•

5 years ago

Sure, dom/debugger is fine by me.

Flags: needinfo?(peterv)

Jason Laster [:jlast]

Updated

•

5 years ago

Status: ASSIGNED → NEW

Marco Mucci [:MarcoM]

Updated

•

5 years ago

Status: NEW → ASSIGNED

Pulsebot

Comment 7

•

5 years ago

Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15bac42cc73a Part 1: Handle some missing includes. r=jimb https://hg.mozilla.org/integration/autoland/rev/63f80a49839e Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug

Dorel Luca [:dluca]

Comment 8

•

5 years ago

Backed out 2 changesets (bug 1529345) for Build Bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251918747&repo=autoland&lineNumber=18858

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=251899466&revision=63f80a49839edb4ff74cd0630b941275f9038e61

Backout:
https://hg.mozilla.org/integration/autoland/rev/d5b2591b6d72c46d90a6d348b9dda94c6f3c8fa2

Flags: needinfo?(lsmyth)

Pulsebot

Comment 9

•

5 years ago

Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf6f6281cb44 Part 1: Handle some missing includes. r=jimb https://hg.mozilla.org/integration/autoland/rev/87aa4894b4a1 Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

5 years ago

Flags: needinfo?(lsmyth)

Dorel Luca [:dluca]

Comment 10

•

5 years ago

Backed out 2 changesets (bug 1529345) for Windows 2012 build bustages

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251942798&repo=autoland&lineNumber=21876

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=87aa4894b4a1002af7b5454416ede5d5332fd498

Backout:
https://hg.mozilla.org/integration/autoland/rev/c1357fdd09bb19a75135f936093feffa97c22c5d

Flags: needinfo?(lsmyth)

Pulsebot

Comment 11

•

5 years ago

Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cd3642e0943 Part 1: Handle some missing includes. r=jimb https://hg.mozilla.org/integration/autoland/rev/e074fcc399d1 Part 2: Add Gecko infrastructure for receiving notifications about debugger-related events. r=jimb,smaug

Alexandru Michis [:malexandru]

Comment 12

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/2cd3642e0943
https://hg.mozilla.org/mozilla-central/rev/e074fcc399d1

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox69: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 69

Bogdan Tara[:bogdan_tara | bogdant]

Updated

•

5 years ago

Regressions: 1554570

Bogdan Tara[:bogdan_tara | bogdant]

Comment 13

•

5 years ago

:loganfsmyth can you, please, take a look?

Your changes seem to trigger a permafail on multiple platforms:

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=b26a70a0fe8f22ee4a5118c7c563ab98a115e692&searchStr=%28tabswitch%29&tochange=d8ccc114a50fd185a8a2b9e7ec9967f2f418bb42&selectedJob=252212663

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=%28tabswitch%29&fromchange=19cf79b6f07d4c5c93d29d6b73d40df4497db657&tochange=40c99f4752f968db32f189243b4432b18d1b3471&selectedJob=252170701

Cosmin Sabou [:CosminS]

Updated

•

5 years ago

No longer regressions: 1554570

Cosmin Sabou [:CosminS]

Comment 14

•

5 years ago

This is not what caused those failures in Bug 1559749: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03b5005ab1a6f8aa13425e4a8d28103a40a8e639&selectedJob=252267008

Flags: needinfo?(lsmyth)

You need to log in before you can comment on or make changes to this bug.