Closed Bug 1554570 Opened 5 years ago Closed 5 years ago

Intermittent PID 3804 | FATAL ERROR: Non-local network connections are disabled and a connection attempt to ping.ie.sogou.com (211.159.235.58) was made.

Categories

(Testing :: Talos, defect, P5)

Version 3
defect

Tracking

(firefox-esr60 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Bebe)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(2 files)

This was regressed by bug 1546880. As it looks like this only happens in some cases for the tp5 sites.

Joel, do you have an idea where the call to ping.ie.sogou.com is made? There is nothing in the tree, which references this host.

Flags: needinfo?(jmaher)
Regressed by: 1546880

odd, I suspect this is a website inside of tp5- probably an edge case that didn't exist before. Unfortunately we are not at a point to remove tp5 from the running as we don't have a way to measure responsiveness of the browser anywhere else- once we have that in tp6 tests or in other scenarios, tp5 could be shut down.

Flags: needinfo?(jmaher)

the way to fix this would be to get the tp5 pageset, find the call to ping.ie.sogou.com and remove it. Then repackage tp5n.zip, upload it, and the problem would be solved.

Joel, could you or someone from SV do that please? I'm moving back to my team, and won't really have the time for that. Thanks!

Flags: needinfo?(jmaher)

:davehunt, can you find someone on your team to work on this?

Flags: needinfo?(jmaher) → needinfo?(dave.hunt)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #6)

:davehunt, can you find someone on your team to work on this?

Yes, thanks for the prompt. Bebe could you get someone to look into this?

Flags: needinfo?(dave.hunt) → needinfo?(fstrugariu)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)

the way to fix this would be to get the tp5 pageset, find the call to ping.ie.sogou.com and remove it. Then repackage tp5n.zip, upload it, and the problem would be solved.

Not verry familiar with tp5 tests
how can we disable the that call?

From digging through the tp5n code I have found some httpdisabled links. Is that the way?

Assignee: nobody → fstrugariu
Flags: needinfo?(fstrugariu) → needinfo?(jmaher)

httpdisabled is the way that wget fixed the problem, that is a safe way to do it. otherwise, I often remove the link that it is making, or make it 127.0.0.1 instead.

Keep in mind you might need to sear for sogou.com and then filter for ping- it might be dynamically built up.

Flags: needinfo?(jmaher)
Depends on: 1555699

Florin, thank you for taking this up. Mind showing what the exact change is which was necessary here?

Flags: needinfo?(fstrugariu)
Attached patch local_history.patch (deleted) — Splinter Review

Not sure how to highlight this...

I searched the archive all the links to ping.ie.sogou.com and added the httpdisabled

This is the solution used in the past to fix this issue and try build proves that it works

Flags: needinfo?(fstrugariu)
Pushed by fstrugariu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec56085daaf1 Non-local network connections are disabled r=jmaher
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Last push time in the intermittent is 2019-06-05 09:52:25

Let's see if we have any intermittent after that time

(In reply to Florin Strugariu [:Bebe] from comment #19)

Last push time in the intermittent is 2019-06-05 09:52:25

Let's see if we have any intermittent after that time

Those were just failures from before the landing on June 5th. So it's all fine.

:whimboo can you, please, take a look?

Flags: needinfo?(hskupin)

Bogdan, it doesn't make sense to add more comments to a bug which is fixed. If there is some kind of new regression a new bug has to be filed. Please also note that this new failure is 127.0.0.1.woopra-ns.com and not ping.ie.sogou.com.

Flags: needinfo?(hskupin)
Flags: needinfo?(fstrugariu)
Flags: needinfo?(btara)

Bug 1559749 was created for the failures mentioned on comment 21. I don't think bug 1529345 is related to these failures, maybe Bug 1554724? Florin, could you try a patch for the new failures? Also please ignore the classifications made against this bug in the last two days. Thanks

Update: Logan's changes in 1529345 are not the ones which caused the regression: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03b5005ab1a6f8aa13425e4a8d28103a40a8e639

Flags: needinfo?(btara) → needinfo?(fstrugariu)
No longer regressed by: 1529345

As stated above this is related to Bug 1559749

The current bug is fixed.

Flags: needinfo?(fstrugariu)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: