Previous visual clone targets can cause the source to stop cloning to a new target after a cycle collection
Categories
(Core :: Audio/Video, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Set media.videocontrols.picture-in-picture.enabled to true
- Visit https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video, and right click on the <video> element of the flower.
- Choose "Loop" to loop the playback of the video, and then play the video.
- Right click on the video again, and choose "Picture in Picture" to open the video in a new Picture in Picture window.
- Play the video for a second or two.
- Right click on the video again, and choose "Picture in Picture" to close the Picture in Picture window.
- Quickly right click on the video again, and choose "Picture in Picture" to re-open the video in a Picture in Picture window.
- Wait
ER:
The video should continue to playback on the Picture in Picture window.
AR:
After a few seconds (after a cycle collection in the content process), the video playback will stop in the Picture in Picture window.
What's happening is that the mVisualCloneSource is never being cleared on the original PiP window's <video>, even as the flower video's mVisualCloneTarget is being updated to the new PiP window's <video>. That means that when the old PiP <video> eventually gets cycle collected, it runs UnbindFromTree, sees that it has a mVisualCloneSource, and stops that clone source from cloning.
Patch coming up.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Comment 3•6 years ago
|
||
Backed out changeset 9b8ef8d81775 (Bug 1532682) for breaking decision task.
Backout: https://hg.mozilla.org/integration/autoland/rev/da85432905df457597fe0be424aefbf3f9af31b8
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=9b8ef8d817750751af255a622bcf208a7db1c3b2&selectedJob=232513606
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232513606&repo=autoland&lineNumber=1058
:Mike, can you please push this again?
|
|
Assignee | |
Comment 4•6 years ago
|
||
(In reply to Cristian Brindusan [:cbrindusan] from comment #3)
:Mike, can you please push this again?
As far as I can tell, this was a one-time infra failure, and I probably shouldn't have been backed out. Oh well, re-landing.
|
|
||
Comment 5•6 years ago
|
||
Sorry about this Mike, no tests ran on your push and #ci advised to push this again.
|
|
Assignee | |
Comment 6•6 years ago
|
||
(In reply to Cristian Brindusan [:cbrindusan] from comment #5)
Sorry about this Mike, no tests ran on your push and #ci advised to push this again.
Oh that's quite alright - sorry for moaning about it. :)
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Description
•