Closed
Bug 1532997
Opened 6 years ago
Closed 6 years ago
Restored One-Click search Engines list is populated only after page refresh
Categories
(Firefox :: Search, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | --- | verified |
| firefox68 | --- | verified |
People
(Reporter: gpalko, Assigned: mikedeboer)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Affected versions
- Nightly 67.0a1 (20190305214137)
Affected platforms
- Windows, MacOS, Ubuntu
Steps to reproduce
- Launch Firefox Nightly
- Open about:preferences#search
- Remove a few search engines from One-Click search engines list
- Click the "Restore Default Search Engines" button
Expected result
- The list is populated with the default search engines
Actual result
- The default search engines list is populated only after page reload/refresh
Regression range:
After running mozregression, it seems that this was introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1524593
|
||
Comment 1•6 years ago
|
||
Drew, could we get this regression investigated and prioritized with regards to 67? Thanks
Flags: needinfo?(adw)
|
||
Comment 2•6 years ago
|
||
Dale, the regression range identified bug 1524593, which I think is related to your work on the search service? Do you have time/knowledge to look into this?
Flags: needinfo?(adw) → needinfo?(dharvey)
Priority: -- → P1
|
Assignee | |
Comment 3•6 years ago
|
||
In that case I think I should fix this :)
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(dharvey)
|
|
Assignee | |
Comment 5•6 years ago
|
||
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b063e2b487b6
Properly await the default engines restoration process to finish, before refreshing the list in about:preferences. r=florian
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
|
||
Updated•6 years ago
|
status-firefox-esr60:
--- → unaffected
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
Reporter | |
Comment 8•6 years ago
|
||
Verified, that the issue is no longer reproducible on Nightly 68(20190421212635) and Beta 67(20190418160535).
You need to log in
before you can comment on or make changes to this bug.
Description
•