Closed Bug 1533447 Opened 6 years ago Closed 6 years ago

Cached browsing contexts are currently not working

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Project Flags:
Fission Milestone M2
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: farre, Assigned: farre)

References

(Blocks 1 open bug)

Details

(Whiteboard: [4/29] patches pushed)

Attachments

(2 files, 1 obsolete file)

Bug 1533447 - Part 1: Sync cached browsing contexts to non-owning child processes. r=nika
(deleted), text/x-phabricator-request
Details
Bug 1533447 - Part 2: Move bc caching to BrowsingContextGroup. r=nika
(deleted), text/x-phabricator-request
Details

Add a cache of browsing contexts to browsing context groups to handle browsing context bf cache.

Assignee: nobody → afarre
Status: NEW → ASSIGNED
Priority: -- → P3
Fission Milestone: --- → M2
Component: DOM → DOM: Core & HTML
Priority: P3 → P2
Blocks: improve-bc

Depends on D28668

Depends on D28669

So, turns out that bc bfcache was actually kind of working.

Part 1 contains the stuff that was missing to actually sync to all participating children.

Part 2 contains the move of the cache from the BrowsingContext compilation unit to a member in the BrowsingContext's group.

Part 3 separates detaching from caching to be able to more clearly see the cache in action.

Attachment #9060424 - Attachment description: Bug 1533447 - Part 3: Separate caching from detaching. r=nika → Bug 1471869 - Re-attached cached contexts in bulk. r=nika

Comment on attachment 9060424 [details]
Bug 1471869 - Re-attached cached contexts in bulk. r=nika

Revision D28670 was moved to bug 1471869. Setting attachment 9060424 [details] to obsolete.

Attachment #9060424 - Attachment is obsolete: true
Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7cd8cc12be3d Part 1: Sync cached browsing contexts to non-owning child processes. r=nika https://hg.mozilla.org/integration/autoland/rev/27b0545208f8 Part 2: Move bc caching to BrowsingContextGroup. r=nika
Whiteboard: [4/29] patches pushed

https://hg.mozilla.org/mozilla-central/rev/7cd8cc12be3d
https://hg.mozilla.org/mozilla-central/rev/27b0545208f8

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1547871
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: