We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=ea127c95a4b9abdff54c49562c253d661622b663

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

150KBytes installer size windows2012-64 pgo 69,005,908.08 -> 69,196,415.00
150KBytes installer size windows2012-32 pgo 66,382,427.42 -> 66,567,919.83

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=19806

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

This is enabling a chunk of code in the Windows build that we've been building and shipping in Linux and macOS since last year. I'm not sure how to evaluate if the 150kB growth is reasonable or not - is there any guidance written anywhere for this?

I can take a look at whether we're building/including any Rust code we don't need (although that should be removed via LTO), and take a general look at the generated code in AudioIPC to see if there are any easy ways to reduce it, but I don't have any immediate suggestions for a solution.

:sledru, could we accept this installer size increase?

Yeah, this is a tiny increase

(In reply to Sylvestre Ledru [:sylvestre] from comment #3)

Yeah, this is a tiny increase

Well, let's close this bug as wontfix.

Matthew, there's no need to work on this anymore.

Thanks!