Closed Bug 1534508 Opened 6 years ago Closed 6 years ago

Startup should handle being launched without calling ProcessUpdates

Categories

(Toolkit :: Startup and Profile System, defect)

59 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: mossop)

References

Details

(Keywords: regression)

Attachments

(1 file)

Not sure when startup changed but it is calling ProcessUpdates when being launched with an existing instance instead of handing off to the existing instance before ProcessUpdates.

Comment on attachment 9050347 [details]
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance.

Haven't had chance to test this yet but I'd expect this to return us to the previous state where we check for existing instances and remote to them before calling ProcessUpdates.

But that leads me to a question, wasn't this always an issue for cases where users were running with -no-remote where we wouldn't check for an existing instance?

Attachment #9050347 - Flags: feedback?(robert.strong.bugs)

I haven't seen bugs on issues when using -no-remote. It is possible it was an issue and I'll check on Windows if there was previously.

It looks like -no-remote also has had this issue since day one of app update though the lack of bug reports make me think it didn't cause crashes such as in bug 1534485

Comment on attachment 9050347 [details]
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance.

I'm fine with giving this feedback+ but with all of the recent changes to startup it is impossible for me to say whether there will be other unintended side affects in startup.

Attachment #9050347 - Flags: feedback?(robert.strong.bugs) → feedback+
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35a77a480420 Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → dtownsend
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: