remove grid usage from comm/mail/base/content/msgHdrView.inc.xul
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(6 files, 5 obsolete files)
I find this grid removal important and complex so I have made a separate bug for this.
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #2)
Something's probably off for the width calculations too. It doesn't "fill
up" the lines properly, and wraps at another (worse) place than it's
supposed to.
Can you explain this a little?
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
There is an issue on Trunk. When you have multiple email addresses, reduce the size of the screen. Click on more and expand the window size. You will see a gap there. I will attach a SS.
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
I am not seeing this issues on Mac. Can you attach a SS for Linux?
Assignee | ||
Comment 12•5 years ago
|
||
I checked on Linux machine. Alignment issue was there and I have it resolved now but I am not able to reproduce the issue for longer "to" fields.
I am still seeing "3 more" label at the end. And also can you ask somebody to check on Windows machine if margin and paddings are correct there or not.
Comment 13•5 years ago
|
||
Please attach what you have.
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
But please attach the patch for it.
Assignee | ||
Comment 17•5 years ago
|
||
It's the same patch with margin changes for Linux.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 18•5 years ago
|
||
I am not able to reproduce following mozmill test failures on Local Machine with the updated patch: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0c7764d4311886512154f32068d5bcb462a0b08c
You told that you are not seeing the "more", can you attach a screenshot, please? Also, can you run the mozmill tests?
Comment 19•5 years ago
|
||
UI wise it looks ok now.
I can reproduce the more issue still. The mail has around 80 recipients, and that is likely a key factor. Try it with enough recipients of various lengths...
For the test failure, in the test you probably instead need to wait for the mode to change (the click will cause the event that triggers that the toggle, but looks like we're checking the state directly now, and that can be before the click handling ran). https://searchfox.org/comm-central/rev/a2afcaf776f3bbff0fe6c2db4c4190942aadca12/mail/test/mozmill/message-header/test-message-header.js#473
I can't reproduce the test failure locally.
Assignee | ||
Comment 20•5 years ago
|
||
I find the solution for the test failures. But I am not able to reproduce the issue with "more" button. I tried with the 80 odd email addresses. Also in test-message-header mozmill tests, we have few test cases with 100 odd email addresses and it is working fine there also. I will attach the screenshot here. We have a mozmill test to check the behavior of the "more" button and it is passing.
Can you check after moving that particular email to another folder or something? and this problem is only for that particular mail or all the other mails?
Assignee | ||
Comment 21•5 years ago
|
||
Assignee | ||
Comment 22•5 years ago
|
||
There are other test cases with 100 odd emails.
Comment 23•5 years ago
|
||
The issue is still there. I'll see if I can get you a test case.
Assignee | ||
Comment 24•5 years ago
|
||
Comment 25•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 26•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c9c2af227b34
remove grid usage from msgHdrView.inc.xul. r=mkmelin
Updated•5 years ago
|
Description
•