[meta] Remove Thunderbird related XUL grid layout usage
Categories
(Thunderbird :: General, task)
Tracking
(thunderbird_esr78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: mkmelin, Unassigned)
References
Details
(Keywords: meta)
+++ This bug was initially created as a clone of Bug #1520625 +++
According to #maildev
13:10:40 - ntim: Paenglab_work: So employees have not planned anything internally yet, but I suspect they will in the coming months as part of the XUL removal (maybe at the same time or after XUL flexbox removal). Anyway, I've been working through mozilla-central usages and I found out that many of the usages don't need to be grids (mainly those with fixed-width columns or fixed-height rows, and single row layouts).
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Grids are starting to disappear from m-c. We'd better get going on this.
https://dxr.mozilla.org/comm-central/search?q=%3Cgrid+path%3Acomm&redirect=false
https://dxr.mozilla.org/comm-central/search?q=%3Cxul%3Agrid+path%3Acomm&redirect=false
https://dxr.mozilla.org/comm-central/search?q=regexp%3AcreateElement.*%5B%27%22%5Dgrid%5B%27%22%5D+path%3Acomm&redirect=false
Comment 2•6 years ago
|
||
Those two should be the easier ones to start with:
Comment 3•6 years ago
|
||
Richard, could you make a start? Looks like the conversion is not so hard, see:
d599d1a73a3a Tim Nguyen — Bug 1525747 - Remove XUL grid layout from browser/components/preferences/sanitize.xul. r=Gijs
760191b55ab3 Tim Nguyen — Bug 1525739 - Remove XUL grid layout from browser/base/content/sanitize.xul. r=Gijs
Comment 4•6 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #2)
Those two should be the easier ones to start with:
This is not so simple as we need to convert https://dxr.mozilla.org/comm-central/source/comm/calendar/base/content/preferences/general.xul#144 too because they are in a deck.
(In reply to Jorg K (GMT+1) from comment #3)
Richard, could you make a start? Looks like the conversion is not so hard, see:
d599d1a73a3a Tim Nguyen — Bug 1525747 - Remove XUL grid layout from browser/components/preferences/sanitize.xul. r=Gijs
760191b55ab3 Tim Nguyen — Bug 1525739 - Remove XUL grid layout from browser/base/content/sanitize.xul. r=Gijs
This was already on my radar. :-)
Updated•6 years ago
|
Comment 5•5 years ago
|
||
All the grid layouts in Thunderbird:
comm/calendar/base/content/calendar-task-view.xul
comm/calendar/base/content/calendar-month-base-view.js
comm/calendar/base/content/dialogs/calendar-error-prompt.xul
comm/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul
comm/calendar/base/content/dialogs/calendar-event-dialog-recurrence.xul
comm/calendar/base/content/dialogs/calendar-print-dialog.xul
comm/calendar/base/content/dialogs/calendar-properties-dialog.xul
comm/calendar/base/content/dialogs/calendar-subscriptions-dialog.xul
comm/calendar/base/content/dialogs/calendar-summary-dialog.xul
comm/calendar/base/content/preferences/alarms.xul
comm/calendar/base/content/preferences/general.xul
comm/calendar/base/content/preferences/views.xul
comm/calendar/lightning/content/lightning-item-iframe.xul
comm/calendar/resources/content/calendarCreation.xul
comm/calendar/resources/content/datetimepickers/datetimepickers.js
comm/calendar/resources/content/publishDialog.xul
comm/chat/content/chat-tooltip.js
comm/mail/components/compose/content/dialogs/EdAdvancedEdit.xul
comm/mail/components/compose/content/dialogs/EdColorProps.xul
comm/mail/components/compose/content/dialogs/EdDictionary.xul
comm/mail/components/compose/content/dialogs/EdHLineProps.xul
comm/mail/components/compose/content/dialogs/edImage.inc.xul
comm/mail/components/compose/content/dialogs/EdInsertMath.js
comm/mail/components/compose/content/dialogs/EdInsertTable.xul
comm/mail/components/compose/content/dialogs/EdInsertTOC.xul
comm/mail/components/compose/content/dialogs/EdReplace.xul
comm/mail/components/compose/content/dialogs/EdSpellCheck.xul
comm/mail/components/compose/content/dialogs/EdTableProps.xul
comm/mail/base/content/editContactPanel.inc.xul
comm/mail/base/content/FilterListDialog.xul
comm/mail/base/content/msgHdrView.inc.xul
comm/mail/components/accountcreation/content/emailWizard.xul
comm/mail/components/addrbook/content/abContactsPanel.xul
comm/mail/components/im/content/addbuddy.xul
comm/mail/components/im/content/imAccountWizard.xul
comm/mail/components/im/content/joinchat.xul
comm/mail/components/preferences/connection.xul
comm/mail/components/preferences/cookies.xul
comm/mail/components/preferences/display.inc.xul
comm/mail/components/preferences/fonts.xul
comm/mail/components/preferences/messengerLanguages.xul
comm/mail/components/preferences/receipts.xul
comm/mailnews/addrbook/prefs/content/pref-directory-add.xul
comm/mailnews/base/content/folderProps.xul
comm/mailnews/base/content/msgAccountCentral.xul
comm/mailnews/base/content/subscribe.xul
comm/mailnews/base/content/virtualFolderProperties.xul
comm/mailnews/base/prefs/content/AccountWizard.xul
comm/mailnews/base/prefs/content/am-copies.inc.xul
comm/mailnews/base/prefs/content/am-identity-edit.xul
comm/mailnews/base/prefs/content/am-junk.xul
comm/mailnews/base/prefs/content/am-main.xul
comm/mailnews/base/prefs/content/am-server-advanced.xul
comm/mailnews/base/prefs/content/am-server.xul
comm/mailnews/base/prefs/content/am-smtp.xul
comm/mailnews/base/prefs/content/SmtpServerEdit.xul
comm/mailnews/base/search/content/CustomHeaders.xul
comm/mailnews/base/search/content/FilterEditor.xul
comm/mailnews/compose/content/sendProgress.xul
comm/mailnews/extensions/mdn/content/am-mdn.xul
comm/mailnews/extensions/newsblog/content/feed-subscriptions.xul
comm/mailnews/extensions/newsblog/content/feedAccountWizard.xul
comm/mailnews/extensions/smime/content/msgCompSecurityInfo.xul
comm/mailnews/import/content/importDialog.xul
Comment 6•5 years ago
|
||
I have a patch for comm/calendar/base/content/preferences/
Comment 7•5 years ago
|
||
Can you add block this bug for future reference so we can keep track and don't overlap the files?
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 8•5 years ago
|
||
There are a few grids not covered here yet, especially in editor/ and calendar/:
https://searchfox.org/comm-central/search?q=%3Cgrid&case=false®exp=false&path=
Comment 9•5 years ago
|
||
Yeah, I am working on it. Will be done in the next 2 to 3 weeks.
Updated•5 years ago
|
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Description
•