Display 40 digit hashes
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect, P1)
Tracking
(Not tracked)
People
(Reporter: pbone, Assigned: sheehan)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In the web UI, eg pages like:
https://hg.mozilla.org/integration/autoland/rev/1467f14d7dd6bc82b4d445dd6505353069d005ff
The 40 digit hash/id of each revision should be shown. it's more useful to use with perfherder compare that way.
Assignee | ||
Comment 1•6 years ago
|
||
I'm in favor of making this change! 👍
In case someone aside from me takes this bug, we will need to modify the Mercurial templates for gitweb_mozilla
to change all instances of {node|short}
to just {node}
. We'll also need to add/modify the patch files in hgtemplates/.patches
. This will likely also require a bunch of cosmetic test fixes to add the full hash to output.
Assignee | ||
Comment 2•6 years ago
|
||
I'll be taking care of this after we do the Mercurial 4.9 upgrade on hg.mo (sometime this week).
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Treeherder has removed support for using 12 character revision
SHAs, due to the performance hit taken by being unable to fully
index a 12 character SHA (since the 40 character SHA is the
canonical version). This commit performs a global replace of
{node|short}
with {node}
for the gitweb_mozilla
theme.
The existing form takes the node
template keyword and passes
it through the short
template filter, producing the 12-character
SHA. Removing the short
filter will cause the full 40-char
SHA to be displayed instead.
Like all other templating changes, we add a patchfile to
hgtemplates/.patches
that encompasses all the changes made by
this commit. Running hgserver/tests/test-template-sync.t
verified that the changes are successfully tracked under version
control.
Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/51905dc214c4
hgtemplates: do not pass node
through short
template filter anywhere r=glob
Assignee | ||
Comment 5•6 years ago
|
||
Deploying this change to hg.mozilla.org now.
Assignee | ||
Comment 6•6 years ago
|
||
This is live.
Description
•