... which is somewhat annoying when trying to paste a changeset ID retrieved from hg.mozilla.org, which doesn't display the full changeset ID unless you look at the raw patch.

Hi! We're in the process of removing support for 12 character revision SHAs from Treeherder, since the 40 character form is the canonical one (to avoid collisions), and supporting <40 character revisions is bad for performance, since the LIKE query can't be fully indexed.

Would you mind filing an issue against hg.mozilla.org to display the full revision there instead? (We've had an org-wide push to using the full SHA, so in general any system that doesn't yet do so is just in the long tail yet to be converted, rather than doing so by design).

Hi Ed,

Can perfherder allow the older 40 character IDs as input until all the tools support them as output?

(be permissive in what you accept and strict in what you produce)

Redirecting to Ionuț, since he owns Perfherder :-)

I would first need a list with the tools you're using, that output older character IDs.

Hi Ionuț,

I use:

• the "hg wip" command that ./mach bootstrap sets up.
• Treeherder
• Perfherder
• hg.mozilla.org

I also use these, but I'm unlikely to use them with perfherder.

• bugzilla
• searchfox.org
• crash-stats.mozilla.com

Thank you.

Relevant to this discussion re Treeherder is bug 1306707 and bug 1340265.

Can this please be fixed, it's annoying to have to jump through hoops to find the 40 bit hashes. it seems like perfherder compare is the only tool that requires/uses them.

Has a bug been filed upstream as mentioned by Ed in comment #2? Since there are bugs filed for removing 12 SHA support, we want to be able to move towards that end goal even if we loosen the requirements here temporarily.

Ionut, you'll need to either refactor (lodash's debounce might help here to prevent unnecessary renders from setting state) or disable part of the revision validation in the compareChooser in order to not require 40 characters.

There's no comment two on this bug. (Never seen that before.)

Er, comment 1 - my bad.

Awesome, thanks!

Thanks Sarah,

I've filed Bug 1539324 and Bug 1539325 (same but against treeherder) for this. I was genuinely confused by the lack of comment 2, thanks.

(In reply to Ed Morley [:emorley] from comment #1)

Hi! We're in the process of removing support for 12 character revision SHAs from Treeherder, since the 40 character form is the canonical one (to avoid collisions), and supporting <40 character revisions is bad for performance, since the LIKE query can't be fully indexed.

That performance problem can be fixed by adding another column to that table containing the 12 digit SHA, placing an index on the column and doing an exact match in the query when the user provides only 12 digits.

I think we can actually close this bug, as hg.mozilla.org now provides full hashes.
I'm preparing to land bug 1553734, as I locally have a working patch for it. Bug 1553734 will let you easily copy the full hash right from Treeherder's main view.