Closed Bug 1541158 Opened 6 years ago Closed 6 years ago

Make changes to full zoom on RDM pages pass through to RDM document

Categories

(DevTools :: Responsive Design Mode, defect, P1)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect

Tracking

(firefox68 verified, firefox69 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: bradwerth, Assigned: bradwerth)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [rdm-mvp])

Attachments

(2 files)

Bug 1541158 Part 1: Passthrough zoom to RDM document.
(deleted), text/x-phabricator-request
Details
Bug 1541158 Part 2: Add a test that only RDM content is affected by full zoom changes.
(deleted), text/x-phabricator-request
Details

Steps to Reproduce:

  1. Open any page.
  2. Toggle on Responsive Design Mode.
  3. Change the full zoom level.

Actual Results: the UI changes zoom levels
Expected Results: the RDM document should change zoom levels

Assignee: nobody → bwerth
Priority: -- → P1

This ensures that any changes to zoom level, when RDM is active,
happen on the content document and not on the RDM interface.

Blocks: 1541692
Blocks: 1541175
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fce9f2905ff0 Part 1: Passthrough zoom to RDM document. r=pbro https://hg.mozilla.org/integration/autoland/rev/efc734d0f506 Part 2: Add a test that only RDM content is affected by full zoom changes. r=pbro
Whiteboard: [rdm-mvp]
Status: NEW → ASSIGNED

https://hg.mozilla.org/mozilla-central/rev/fce9f2905ff0
https://hg.mozilla.org/mozilla-central/rev/efc734d0f506

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Blocks: rdm-zoom

Hi Guys, When the user Zooms in using the CTRL + Scroll Wheel from the mouse the entire Page zooms in and out including the RDM UI bar but if we Use CTRL + +/- then only the content zooms in and out the UI bar remains at 100%.
Is this the correct behavior ? Is it intended for the entire page to zoom in and out when using the Mouse wheel ?

Flags: needinfo?(pbrosset)
Flags: needinfo?(bwerth)

No this behavior is not correct. This is still an open bug that is currently tracked and worked on in bug 1516413.

Flags: needinfo?(pbrosset)
Flags: needinfo?(bwerth)

This issue is Verified as Fixed in 69.0a1 (2019-06-03).

Status: RESOLVED → VERIFIED
status-firefox68: fixed → verified
status-firefox69: --- → verified
Regressions: 1602799
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: