Combined address bar continues to treat the address as search string after entering file:
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox66 | --- | wontfix |
| firefox67 | --- | verified |
| firefox68 | --- | verified |
People
(Reporter: hsivonen, Assigned: mak)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: privacy, regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Screenshot
Steps to reproduce
- Run Nightly with a fresh profile
- Type file:///home in the address bar
Actual results
Search suggestions are offered, such as "/home/linuxbrew/.linuxbrew/bin is not in your path".
Expected results
For privacy reasons, expected Firefox to stop sending the location bar entry to search engines if the string starts with "file:" (or with a URL scheme generally).
| Comment hidden (obsolete) |
|
Reporter | |
Comment 2•6 years ago
|
||
|
|
Reporter | |
Comment 3•6 years ago
|
||
If a search is chosen, it goes to Google with the suggested string.
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
Assignee | |
Comment 6•6 years ago
|
||
I was wrong, I can also reproduce on Windows.
|
|
Assignee | |
Comment 7•6 years ago
|
||
Fixes the tokenizer to recognize file:/// urls, plus adds a second layer of
protection, so that if URI fixup thinks the typed string may be an url, we don't
fetch suggestions for it.
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 10•6 years ago
|
||
Comment on attachment 9056068 [details]
Bug 1541399 - Ensure we don't fetch search suggestions for file urls. r=adw
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1514780
- User impact if declined: file:// urls may be sent to the current search engine to get search suggestions
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Steps in comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): simple patch with automated tests
- String changes made/needed: none
|
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
||
Comment 11•6 years ago
|
||
Let's get it verified by QA on Nightly before uplifting to beta.
|
||
Updated•6 years ago
|
|
||
Comment 12•6 years ago
|
||
I have reproduced this issue using Firefox 68.0a1 (2019.04.03) on Ubuntu 18.04 x64.
I can confirm this issue is fixed, I verified using Firefox 68.0a1 latest Nightly on Win 10 x64, macOS 10.14 and Ubuntu 18.04 x64.
|
|
||
Comment 13•6 years ago
|
||
Comment on attachment 9056068 [details]
Bug 1541399 - Ensure we don't fetch search suggestions for file urls. r=adw
P1 regression, low risk patch with tests verified by QA on Nightly, uplift approved for 67 beta 10, thanks!
|
||
Comment 14•6 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 15•6 years ago
|
||
I can confirm this issue is fixed, I verified using Firefox 67.0b10 on Win 10 x64, macOS 10.14 and Ubuntu 18.04 x64.
Description
•