Affected versions

• Fx Fx72.0a1
• Fx 71.0b11

Affected platforms

• Windows 10
• Ubuntu 18.04
• macOS 10.15

Steps to reproduce

1. Launch Firefox.
2. Navigate to about:config, set keyword.enabled to false and restart the browser.
3. In a new tab write moz.

Expected result

• No search suggestions are displayed for the word.

Actual result

• Search suggestions are displayed.

Regression range

• Will come back with a regression range ASAP.

Additional notes

• This occurs if any website is visited (e.g. navigate to facebook.com then type face in the awesomebar in a new tab) and the root word of the website is typed in a new tab url bar.

afaik, keyword.enabled has nothing to do with search suggestions, it only controls the preselected result so it's never a search.

Why are you expecting suggestions to not appear? Maybe it's badly documented somewhere.

Hey Marco,
You are partly correct about the pref but there are some inconsistencies in the behavior.
Before visiting a website (with the pref set to false) there are no search suggestions or website suggestions of any kind. After the website is visited, the first letters in the website name generates search suggestions as well.
Is this not the intended functionality of the pref? If not, why does it prevent search suggestions in the first place?

you are right, there is some inconsistency here, if I type "arte" with keyword.enabled set to false I'd expect to get a first result as "http://arte/ - Visit" and search suggestions.

I suspect this may be a regression of bug 1541399 and in particular https://searchfox.org/mozilla-central/rev/a78233c11a6baf2c308fbed17eb16c6e57b6a2ac/toolkit/components/places/UnifiedComplete.jsm#1461
when keyword.enabled is true any string will match a url, but if the string doesn't look like a url we should still fetch suggestions.

We're at mid beta and this has been shipping since 68 so calling it wontfix for 72.

Too late for a fix in 72 but we could still take a patch for 74 and possibly 73.

(In reply to Marco Bonardo [:mak] from comment #3)

I suspect this may be a regression of bug 1541399 and in particular https://searchfox.org/mozilla-central/rev/a78233c11a6baf2c308fbed17eb16c6e57b6a2ac/toolkit/components/places/UnifiedComplete.jsm#1461
when keyword.enabled is true any string will match a url, but if the string doesn't look like a url we should still fetch suggestions.

Hi Marco, will you be able to resolve this regression? Or could you recommend anyone else?

We'll look into it when possible, this is an edge case considered it affects a non-default and non-ui-exposed pref.