Closed Bug 1542929 Opened 6 years ago Closed 3 years ago

Remove mReferenceFrame from nsDisplayItem

Categories

(Core :: Web Painting, task, P3)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox68 --- wontfix
firefox94 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1542929 - Remove mReferenceFrame from nsDisplayItem. r?miko
(deleted), text/x-phabricator-request
Details

It looks like we barely use this, and mainly just as an unnecessary shortcut.

Removing it will save 8 bytes per item, so we should probably just do that.

Type: defect → task

Depends on D124008

Assignee: nobody → matt.woodrow
Status: NEW → ASSIGNED
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/414aa7ff05fe Remove mReferenceFrame from nsDisplayItem. r=miko

Backed out 7 changesets (Bug 1728050, Bug 1728251, Bug 1728232, Bug 1542929, Bug 1714138, Bug 1728258) for causing reftest failures.
Backout link
Push with failures R8
Also on multiple platforms - Rs6 R5
Failure Log

Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a84a36b9dc4 Remove mReferenceFrame from nsDisplayItem. r=miko

https://hg.mozilla.org/mozilla-central/rev/9a84a36b9dc4

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

Backed out for causing Bug 1424348 a=backout
Backout link : https://hg.mozilla.org/mozilla-central/rev/e8e345cec68d8e71ba6f6f3c5ff2fe33605c670f

Status: RESOLVED → REOPENED
status-firefox94: fixed → ---
Resolution: FIXED → ---
Target Milestone: 94 Branch → ---
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c4f88bd2fae Remove mReferenceFrame from nsDisplayItem. r=miko

https://hg.mozilla.org/mozilla-central/rev/5c4f88bd2fae

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
status-firefox68: affected → wontfix
Flags: needinfo?(matt.woodrow)
Regressions: 1730525
No longer regressions: 1730525
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: