Closed Bug 1728050 Opened 3 years ago Closed 3 years ago

Implement opacity flattening using WR serialization

Categories

(Core :: Web Painting, enhancement)

Product:
Core
Component:
Web Painting
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

Bug 1728050 - Move opacity flattening to be part of WR DL serialization. r?miko
(deleted), text/x-phabricator-request
Details

Currently opacity flattening is implemented as part of display list iteration, where we flatten away no-op containers.

This works by mutating the child items, so that the opacity group item is no longer needed.

Mutating items is painful, since we have to save and restore their state, costing memory and time when we use RDL.

We can instead just push the opacity value onto the WR DisplayListBuilder object as we iterate, if all descendants support that, and then we can pull the current inherited opacity when we process the child items.

Blocks: 1728232
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66038c15fe54 Move opacity flattening to be part of WR DL serialization. r=miko

Backed out 7 changesets (Bug 1728050, Bug 1728251, Bug 1728232, Bug 1542929, Bug 1714138, Bug 1728258) for causing reftest failures.
Backout link
Push with failures R8
Also on multiple platforms - Rs6 R5
Failure Log

Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3afd6aee7849 Move opacity flattening to be part of WR DL serialization. r=miko

https://hg.mozilla.org/mozilla-central/rev/3afd6aee7849

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

Backed out for causing Bug 1424348 a=backout
Backout link : https://hg.mozilla.org/mozilla-central/rev/e8e345cec68d8e71ba6f6f3c5ff2fe33605c670f

Status: RESOLVED → REOPENED
status-firefox94: fixed → ---
Resolution: FIXED → ---
Target Milestone: 94 Branch → ---
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afed00aaaf0f Move opacity flattening to be part of WR DL serialization. r=miko

https://hg.mozilla.org/mozilla-central/rev/afed00aaaf0f

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Flags: needinfo?(matt.woodrow)
Regressions: 1734007
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: