Closed Bug 1543555 Opened 6 years ago Closed 6 years ago

Stop using our linker to resolve libc/libm symbols when not strictly necessary

Categories

(Core :: mozglue, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla68
Root Cause ?
Tracking Status
firefox67 blocking verified
firefox68 --- verified

People

(Reporter: glandium, Assigned: glandium)

References

Details

Crash Data

Attachments

(1 file)

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/d5ce9b28780d Stop using our linker to resolve libc/libm symbols when not strictly necessary. r=froydnj
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Mike, can we uplift this patch to beta? Thanks

Flags: needinfo?(mh+mozilla)

Verified that the ARMv7 Build no longer crashes on start on Android Q.

Severity: normal → major

Comment on attachment 9057426 [details]
Bug 1543555 - Stop using our linker to resolve libc/libm symbols when not strictly necessary.

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: Fennec not starting up properly on Android Q
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Make sure Fennec starts on all Android versions we can test manually, because automation has limited coverage.
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): Technically speaking, all the patch does is disable the changes from bug 1412405 and bug 1081034 when running on Android >= 5.0. Those changes were to fix startup crashes, so the worst that can happen is we got the version limit wrong and crashes start to happen at startup on some Android versions. That should be visible quickly, though (as they are the "always crash" type), but we wouldn't get crash reports for those. But I think we have crash data on the play store for things that we don't catch with our crash reporter?
  • String changes made/needed: N/A
Flags: needinfo?(mh+mozilla)
Attachment #9057426 - Flags: approval-mozilla-beta?
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
Whiteboard: [qa-triaged]

Comment on attachment 9057426 [details]
Bug 1543555 - Stop using our linker to resolve libc/libm symbols when not strictly necessary.

Firefox for Android blocker, uplift approved for our next beta, thanks

Attachment #9057426 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,

I was not able to reproduce this issue anymore on Beta 67.0b13 using a Google Pixel XL with Android Q.

I visited several popular websites and firefox did not crash on startup and rendered the pages correctly.

Due to my findings, I'll mark this issue as verified in Firefox 67.

Status: RESOLVED → VERIFIED
Flags: qe-verify+ → qe-verify-
Whiteboard: [qa-triaged]
Flags: qe-verify-
Crash Signature: [@ sftk_setStringName]

Please specify a root cause for this bug. See :tmaity for more information.

Root Cause: --- → ?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: