Closed Bug 1544214 Opened 6 years ago Closed 6 years ago

Not able to load yandex

Categories

(Firefox :: Search, defect)

68 Branch
defect
Not set
major
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: 37313, Assigned: daleharvey)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Firefox nightly version since yesterday, 12.04.2019
If you type in address bar anything without prefix https:// or http:// then
"go to the address" or "search by word" does not happen - nothing happens at all.

if you type in addres bar like yandex.ru and press enter = nothing happens at all.
if you type in addres bar FULL address like https://yandex.ru and press enter = page loads normally.
And no word search at all

Actual results:

Nothing

Expected results:

go to the typed site or word search

Component: Untriaged → Address Bar

Please try safe mode https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Also check you don't have userchrome.css or a chrome folder in your profile folder.

Flags: needinfo?(37313)

In Firefox safe mode = same, nothing change, this error present.
userchrome.css = there is no file with such name

Marco Bonardo [::mak]
If you update Nightly right now, then you NOT SEEN this error?
RU, 64bit - Have you ever tried to reproduce this error?

Flags: needinfo?(37313)

I tried install EN version Nightly = error disappear, but in search engines disappear also yandex!
I tried choose google search engine, then update RU version Nightly = error still present, see picture i add.

Attached image 11.jpg (deleted) —

I can reproduce this issue on ru build Nightly Build ID 20190413095252.

And the following error appear in Browser console:

getDefaultEngineInfo: No default engine SearchService.jsm:4195
getDefaultEngineInfo resource://gre/modules/SearchService.jsm:4195
InterpretGeneratorResume self-hosted:1286
AsyncFunctionThrow self-hosted:843
uncaught exception: 2147500037 3
2147500037 2 ContentSearch.jsm:364
_currentEventPromise resource:///modules/ContentSearch.jsm:364
InterpretGeneratorResume self-hosted:1286
AsyncFunctionThrow self-hosted:843

Status: UNCONFIRMED → NEW
Ever confirmed: true

Ok, let me add to this bug, sicne i "had" similar problem. Actual ru locale is NOT needed (in my case). All you need to trigger is to in about:preferences - General - Languages add Russian language and make sure its on top of list. Restart and your browser is broken. Remove it from list or move it to bottom, restart and problem fixed.

Also, in my case i had significantly different errors in console:

Unable to initialize search service. PlacesSearchAutocompleteProvider.jsm:45
initialize resource://gre/modules/PlacesSearchAutocompleteProvider.jsm:45
AsyncFunctionThrow self-hosted:843

uncaught exception: 2147500037 UrlbarUtils.jsm:170:34

NS_ERROR_FAILURE: Failure'Failure' when calling method: [nsISearchService::getEngineByAlias] UrlbarUtils.jsm:170

Just to acknowledge I've seen this. It is the weekend though, I'll try and have a look later today if someone doesn't beat me to it.

Comment 9 is probably better handled in bug 1544273.

Here we'll just look at the non-en-US issues.

I've just loaded the ru build with some more debugging information. I found this part:

_init: failure loading engines: Error: File resource://search-extensions/yandex-ru/ does not contain a valid manifest
loadManifest@resource://gre/modules/addons/XPIInstall.jsm:550:11
async*installBuiltinAddon@resource://gre/modules/addons/XPIInstall.jsm:3711:23
XPIProvider[meth]@resource://gre/modules/addons/XPIProvider.jsm:2888:28
installBuiltinAddon@resource://gre/modules/AddonManager.jsm:2056:33
installBuiltinAddon@resource://gre/modules/AddonManager.jsm:3379:33
_loadEngines@resource://gre/modules/SearchService.jsm:2918:30
async*_init@resource://gre/modules/SearchService.jsm:2646:18
async*init@resource://gre/modules/SearchService.jsm:3650:18
getDefault@resource://gre/modules/SearchService.jsm:4176:16
delayedStartupInit@chrome://browser/content/browser.js:3984:21
_delayedStartup@chrome://browser/content/browser.js:1634:19
EventListener.handleEvent*onLoad@chrome://browser/content/browser.js:1560:12
EventHandlerNonNull*@chrome://browser/content/browser.xul:104:39

This makes me believe there's two issues:

  1. We don't fail gracefully if a single engine cannot be loaded. I think we should have a try/catch around this block.

  2. resource://search-extensions/yandex-ru/ does not exist, but resource://search-extensions/yandex/ does.

I've not had time to look into this bit yet, but hopefully Dale knows what's happening here.

Flags: needinfo?(dharvey)
Summary: Address bar not working without https:// or http:// → Not able to load yandex

I have the same problem.

I lost all my search engines since the update.

Can't add new search engines.

Adress bar doesn't work unless I type the full URL with HTTPS or HTTP. My adress bar is somehow also a searchbar!(seperated for a reason!!!)

Search bar doesn't work. I don't have search engines, obviously.

If I right click on a link the option to open the link in a new tab, new window or private window doesn't work. I also can't bookmark links. Sometimes I get the menu with way to many option, as if Firefox can't determine what I'm pointing on.

I don't use the English Firefox.

There are several people on firefox subreddit with the same problems.

I agree about the try catch, and I think we need new tests to ensure we catch this before, but I might not be able to write them until tomorrow so put the fix up sans tests for now

(In reply to lolbrol from comment #16)

I have the same problem.

I expect this will affect people in the following locales: az, be, kk, ru, tr. Regions related to those may be affected. Hopefully this will be fixed in one of the next two nightlies.

(In reply to Dale Harvey (:daleharvey) from comment #17)

I agree about the try catch, and I think we need new tests to ensure we catch this before, but I might not be able to write them until tomorrow so put the fix up sans tests for now

Yes, good idea. I think some of this is also going to be covered by the unit testing that we're writing soon, but it'd still be good to have a specific test for this fallback (hence marking as leave-open for now).

I've submitted the patch to Lando so it should land soon. I'll see if there's any Sheriffs around to see if we can get it into the next nightly.

Keywords: leave-open
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fde3dab694e Add Yandex to list of multi locale search extensions. r=Standard8

Although my earlier comment was marked as off topic, I should point out that I'm in the RU region. I just happen to use the en-US version of Nightly. I also delete Yandex.

Regressed by: 1544392

I'm using the Dutch version in Belgium(BE). The problem is fixed. Other locales still may be affected of course.

Thanks for the quick fix.

No longer regressed by: 1544392
Attachment #9059233 - Attachment description: Bug 1544214 - Ensure all engines in list.json can be loaded → Bug 1544214 - Ensure all engines in list.json can be loaded. r?Standard8
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e07782ebf0f2 Ensure all engines in list.json can be loaded. r=Standard8
Component: Address Bar → Search
Blocks: 1544300
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Iteration: --- → 68.3 - Apr 15 - 28
Points: --- → 3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: