Some One-Click Search Engines are constantly readded after each Mozilla Firefox update after landing patches from bug #1496075
Categories
(Firefox :: Search, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | + | verified |
People
(Reporter: Virtual, Assigned: daleharvey)
References
(Regression)
Details
(Keywords: nightly-community, regression, reproducible)
Attachments
(2 files, 2 obsolete files)
STR:
- Go to Options ( about:preferences )
- Select "Search" tab ( about:preferences#search )
- Remove all One-Click Search Engines leaving only "Google"
- Wait for daily Mozilla Firefox Nightl update
and after update:
- Amazon.com
- Wikipedia (en)
are readded to One-Click Search Engines
Latest regression form about few days.
Reporter | ||
Comment 1•6 years ago
|
||
I suspect that it can be caused by one of these bugs:
Bug #1496075 - Support loading search extensions on startup
Bug #1486820 - [meta] Convert builtin opensearch files to webextensions
@ Dale Harvey (:daleharvey) - Any ideas or it's missed call?
Reporter | ||
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 3•6 years ago
|
||
Mozregression-GUI pointing me to:
bug #1496075 - Part 4: Delete searchplugins. r=mixedpuppy
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Comment 4•6 years ago
|
||
Yeh this will almost certainly have been caused by my patches, taking a look
Reporter | ||
Updated•6 years ago
|
I posted this, yesterday, in Bug 1544214 but someone marked it as off topic and suggested this bug was more appropriate.
Just adding this. I'm in the RU region but I'm using the 'en-US' build of Nightly. Starting yesterday all search engines were removed and the address bar became unusable. After restarting the browser again some search engines were added: Bing, DDG, Wikipedia, Google, Twitter and Amazon.
Yesterday, I readded my chosen search engines, primarily from Mycroft but also two two from AMO but once again, following the earlier update today, everything was reset.
I also have the 'Automatically update search engines' option unchecked.
Mozregression:
Bug 1496075 - Part 4: Delete searchplugins. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1a92c531a9af2815c1a8bb79716f0dd9d8b883a8&tochange=7e886806ae987d8008486c878921a8a33329c55b
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 6•6 years ago
|
||
Ok no longer have a failing test for this, my build had leftover engines in the objdir which broke the test.
I deleted some builtin engines last week and have done 3/4 updates since then and not had them restored, I think this may have been fallout from the various invalid engines bugs
Pulse, Virtual_ManPL, can you still reproduce this bug? if so if you could post the logs of it happening with browser.search.log=true please? Thank you
(In reply to Dale Harvey (:daleharvey) from comment #6)
Ok no longer have a failing test for this, my build had leftover engines in the objdir which broke the test.
I deleted some builtin engines last week and have done 3/4 updates since then and not had them restored, I think this may have been fallout from the various invalid engines bugs
Pulse, Virtual_ManPL, can you still reproduce this bug? if so if you could post the logs of it happening with browser.search.log=true please? Thank you
@Dale
Search engines are not being replaced for me either. I hadn't noticed before because i tend to use my own engines and disable update.
Here's a the logs from a new profile with several engines removed - https://pastebin.com/8FFF5DRV
Reporter | ||
Comment 8•6 years ago
|
||
I also can't reproduce it anymore, since Mozilla Firefox Nightly 68.0a1 (2019-04-24). Looking on landed bugs and patches, looks like probably patch from bug #1544392 fixed this issue.
Thank you very much! \o/
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 9•6 years ago
|
||
Hmm, odd, in latest Mozilla Firefox Nightly 68.0a1 (2019-04-26) (64-bit) [ https://hg.mozilla.org/mozilla-central/rev/b13f2b24ae625d16fdeeb61cdec10978c3c75638 ] update I can still reproduce this issue, so I'm reopening this bug.
@ Dale Harvey (:daleharvey) & Pulse - Could you also confirm this on your side?
Reporter | ||
Comment 10•6 years ago
|
||
FYI - I updated to latest Mozilla Firefox Nightly 68.0a1 (2019-04-27) (64-bit) [ https://hg.mozilla.org/mozilla-central/rev/7bdb46cc5ec6221c8df10f0a239dc4faf457488d ] and unfortunately it wasn't just one thing.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 12•5 years ago
|
||
I want to add that issue is still reproducible for me even in latest Mozilla Firefox Nightly 68.0a1 (2019-05-07) [ 63bc837753d653ab13635e432400c1b6d31d12ca ].
Assignee | ||
Comment 13•5 years ago
|
||
Still trying to reproduce this, I had a false negative in my previous test. If you could possibly run with 'browser.log.enabled=true' and give me the log output of a restart where this occurs it would be extremely useful. Cheers
Reporter | ||
Comment 14•5 years ago
|
||
I hope I understood it correctly.
I added "browser.log.enabled" boolean type preference with "true" value to about:config.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 16•5 years ago
|
||
Argh I need to be more careful when I share the pref name, I meant browser.search.log=true sorry (and thanks)
Reporter | ||
Comment 17•5 years ago
|
||
Done, please have a look.
Assignee | ||
Comment 18•5 years ago
|
||
Comment 19•5 years ago
|
||
Comment 20•5 years ago
|
||
bugherder |
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 21•5 years ago
|
||
Cheers for the log, see you in the new bug (clearing needinfo)
Reporter | ||
Comment 22•5 years ago
|
||
I'm marking this bug as VERIFIED and follow-up is being tracked in bug #1552559.
Assignee | ||
Updated•5 years ago
|
Comment 23•5 years ago
|
||
Search engines replaced with Google and Amazon despite having unchecked "update search engines":
Firefox version 71.0 - Probably similar to a bug reported for an earlier version (reported by "Pulse" about 8 months ago). I have unchecked "automatically update search engines" and it was still unchecked after update to Firefox 71.0. Still, it added Google and Amazon and changed the default search engine to Google without notice. Because of the tracking and ads I try to reduce the interaction with those big players to a minimum, but then the things re-appear, also with an earlier update of Firefox (to 69 I think).
Please re-open issue
Comment 24•5 years ago
|
||
(In reply to stephan_thomann from comment #23)
Please re-open issue
Your issue is highly unlikely to be this one. Please can you file a new bug for us, so we can more easily track it, commenting on closed bugs about issues tends to end up getting the comments lost.
If you could include the output from "Help" -> "Troubleshooting Information" in the new bug that would be useful.
Also, as much information as possible about what search engines you have installed / hidden / etc, and when this occurs would be useful.
Description
•