Closed Bug 1544303 Opened 6 years ago Closed 5 years ago

remove grid usage from comm/mailnews/base/content/virtualFolderProperties.xul

Categories

(Thunderbird :: General, task)

Product:
Thunderbird
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 68.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(4 files, 2 obsolete files)

after.png
(deleted), image/png
Details
before.png
(deleted), image/png
Details
Screenshot 2019-04-23 at 8.55.35 PM.png
(deleted), image/png
Details
Bug-1544303-remove_grid_virtualFolderProperties.patch
(deleted), patch
khushil324
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → khushil324
Status: NEW → ASSIGNED
Attachment #9058159 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9058159 [details] [diff] [review] Bug-1544303-remove_grid_virtualFolderProperties.patch Review of attachment 9058159 [details] [diff] [review]: ----------------------------------------------------------------- The items are now in quite the wrong places. Please compare with trunk.
Attachment #9058159 - Flags: review?(mkmelin+mozilla) → review-
Attached image after.png (deleted) —

Screenshot after applying patch

Attached image before.png (deleted) —

Screenshot before applying patch

(In reply to Magnus Melin [:mkmelin] from comment #2)

The items are now in quite the wrong places. Please compare with trunk.

I don't find any problem with this. Can you elaborate a little what was the exact problem?

That's not the right dialog... Right click an existing search folder to see it. It's pretty obvious once you get there.

Attachment #9058159 - Attachment is obsolete: true
Attachment #9060006 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9060006 [details] [diff] [review] Bug-1544303-remove_grid_virtualFolderProperties.patch Review of attachment 9060006 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=mkmelin ::: mailnews/base/content/virtualFolderProperties.xul @@ +45,5 @@ > + <vbox> > + <hbox flex="1" align="center"> > + <label value="&name.label;" > + accesskey="&name.accesskey;" > + control="name"/> where it fits the line width, it's more useful to have it all on one line @@ +83,5 @@ > + oncommand="chooseFoldersToSearch();"/> > + </hbox> > + </vbox> > + <vbox flex="2"> > + </vbox> is this needed?
Attachment #9060006 - Flags: review?(mkmelin+mozilla) → review+

Without vbox, it will look something like this. Is it okay or we should continue with previous layout ?

Seems that just removes some extra space above "Configure the search criteria". That's fine I think, and preferable even.

(In reply to Magnus Melin [:mkmelin] from comment #10)

Seems that just removes some extra space above "Configure the search criteria". That's fine I think, and preferable even.

It is actually removing the 3rd Column which is empty like https://bugzilla.mozilla.org/show_bug.cgi?id=1544303#c3 so width of textbox and menubar will increase.

Right, I'd still go for it :)

Attachment #9060006 - Attachment is obsolete: true
Attachment #9060462 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8e40e1972fde
remove grid usage from virtualFolderProperties.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
Type: defect → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: