Closed Bug 1545046 Opened 6 years ago Closed 5 years ago

Hide the container label in the URL bar in small windows

Categories

(Firefox :: Address Bar, enhancement, P3)

enhancement
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 75
Iteration:
75.1 - Feb 10 - Feb 23
Tracking Status
firefox75 --- verified
firefox76 --- verified

People

(Reporter: freddy, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Looking at https://twitter.com/ericlaw/status/1118167961829871622 and generally looking at what collapses and who is making space for whom in the URL bar (and round it) when a window is resized to decreasing width, it would be nice if we would give security indicators and the actual URL a higher priority.

Things we could do:

  • remove the container name, just keeping the icon
  • we could collapse all browserActions (Firefox Accounts button, Library, etc.) into the overflow icon.
  • collapse all pageActions (screenshots, web compat report, bookmark etc.) into a "..." that consumes all.

I don't think its an important security bug, but Eric has a point.

@jkt: I'm told there is a meta bug which this should block but I couldn't find it. Will you mark it as dependent please?

I can't find a dupe but this certainly has been raised before (perhaps on the github wrongly).

I previously suggested:

  • We drop the container name before we remove the icon (hovering could have a tooltip to the name).
  • We elide or remove EV before eliding the URL.

I think this got de-prioritised due to containers adoption however it's certainly possible without.

Type: defect → task
Component: Security → Address Bar

I agree that just dropping the container name is a good option, though I'm not sure anyone is available for doing that work at the moment.

Summary: reconsider collapsing priorities in URL bar when shrinking window width → reconsider collapsing the container label in the URL bar when shrinking window width
Type: task → enhancement
Summary: reconsider collapsing the container label in the URL bar when shrinking window width → Hide the container label in the URL bar in small windows
Assignee: nobody → dao+bmo
No longer blocks: https-everything
Status: NEW → ASSIGNED
Iteration: --- → 75.1 - Feb 10 - Feb 23
Points: --- → 3
Points: 3 → 2
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77291083babb Hide the container label in the URL bar in small windows. r=mak
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

Dao, should we uplift this?

Flags: needinfo?(dao+bmo)

I don't see a need to uplift this.

Flags: needinfo?(dao+bmo)
Depends on: 1616454
Blocks: 1616454
No longer depends on: 1616454
QA Whiteboard: [qa-75b-p2]

Marking this as verified on:
Ubuntu 18.04, macOS 10.13, Windows 10 using:

76.0a1 Build ID 20200331093527
75.0b10 Build ID 20200326191140

with the note that the bug 1624576 is a bit more affected when adding the container tab icon - maybe an improvement sugestion would be adding transparency to the container icon in this case?

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: