User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

I have a lot of bookmarks in my bookmark toolbar, and 3 buttons on the right side of my address bar.

Actual results:

When I visit sites that make Firefox put extra buttons on the left side of the address bar, like the reader mode or blocked autoplay buttons, it becomes impossible to put my cursor in the address bar.

Expected results:

Firefox should move more bookmarks to the overflow menu of the bookmars toolbar to make room for the address bar.

In bug 1545046 this was improved for smaller windows, but that won't help for wide windows with loads of stuff in the toolbar on its own. Between bug 1545046 and all the related bugs I'm not sure if we also made other changes that'd result in the page actions etc. collapsing if there is no space. Dão?

I think this should be in the toolbars & customization category, not the address bar category, because the best way to fix it is to move more bookmark items to the overflow menu. As you can see from my attached screenshot, the bookmark toolbar is hogging tons of space that could be used by the address bar.

(In reply to svgPhoenix from comment #2)

I think this should be in the toolbars & customization category, not the address bar category, because the best way to fix it is to move more bookmark items to the overflow menu. As you can see from my attached screenshot, the bookmark toolbar is hogging tons of space that could be used by the address bar.

The only way that's going to happen is if the address bar's minimum space requirements get adjusted so it takes the space required for the input to function. Some of that happened in bug 1545046 and its deps, there may be more left to do (though I don't think all of the changes have made it to release yet, so it's possible this is better in nightly already). That is ultimately a call for the address bar folks. The way overflow in the toolbar works is nothing will be moved to the overflow until there is literally not enough space. Right now, the overflow code thinks there is space; if the address bar said (for example) that at a minimum, it needed to be twice as wide as it is in your screenshot then this problem wouldn't happen.

(In reply to :Gijs (he/him) from comment #3)

The only way that's going to happen is if the address bar's minimum space requirements get adjusted so it takes the space required for the input to function. Some of that happened in bug 1545046 and its deps, there may be more left to do (though I don't think all of the changes have made it to release yet, so it's possible this is better in nightly already). That is ultimately a call for the address bar folks. The way overflow in the toolbar works is nothing will be moved to the overflow until there is literally not enough space. Right now, the overflow code thinks there is space; if the address bar said (for example) that at a minimum, it needed to be twice as wide as it is in your screenshot then this problem wouldn't happen.

Oh okay, that makes sense. Thanks for the explanation!

Bug 1601334 fixed the reported case -- the address bar now has a larger minimum width.

There's still room for improvement but we're entering edge case territory here. For instance, we should ideally use the address bar width rather than the window width to decide when to hide page action icons and the container label. It's just more effort to implement it that way and I'm not sure that's worth it at this point.