Closed
Bug 1545907
Opened 6 years ago
Closed 5 years ago
remove grid usage from comm/mailnews/base/prefs/content/am-identity-edit.xul
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(3 files, 2 obsolete files)
No description provided.
Assignee | ||
Updated•6 years ago
|
Comment 2•5 years ago
|
||
Comment on attachment 9059634 [details] [diff] [review] Bug-1545907_remove-grid-am-identity-edit.patch Review of attachment 9059634 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/base/prefs/content/am-identity-edit.xul @@ +70,5 @@ > + <hbox> > + <vbox> > + <hbox flex="1" align="center"> > + <label value="&name.label;" control="identity.fullName" > + accesskey="&name.accesskey;"/> these are now much less wider than they used to be I see on trunk this whole thing is actually larger than it should be so the Manage identities button is pushed out of view and needs to be scrolled into view to find/click. (Because the text boxes are over wide.) Maybe we should fix that first. @@ +126,5 @@ > > + <hbox align="center"> > + <checkbox id="identity.attachVCard" label="&attachVCard.label;" > + flex="1" accesskey="&attachVCard.accesskey;"/> > + <button class="push" name="editVCard" label="&editVCard.label;" please remove the name while you're here - it doesn't do anything @@ +128,5 @@ > + <checkbox id="identity.attachVCard" label="&attachVCard.label;" > + flex="1" accesskey="&attachVCard.accesskey;"/> > + <button class="push" name="editVCard" label="&editVCard.label;" > + accesskey="&editVCard.accesskey;" oncommand="editVCard()"/> > + <label hidden="true" id="identity.escapedVCard"/> and move id first
Attachment #9059634 -
Flags: review?(mkmelin+mozilla) → review-
Updated•5 years ago
|
Type: defect → task
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #9059634 -
Attachment is obsolete: true
Attachment #9061343 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9061343 [details] [diff] [review] Bug-1545907_remove-grid-am-identity-edit.patch Review of attachment 9061343 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/themes/osx/mail/accountManage.css @@ +22,4 @@ > } > > .signatureBox { > + flex-grow: 1; only on mac? ::: mailnews/base/prefs/content/am-identity-edit.xul @@ +68,5 @@ > <groupbox> > <label class="header">&publicData.label;</label> > + <hbox> > + <vbox> > + <hbox flex="1" align="center"> probably don't need the align="center"?
Attachment #9061343 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 6•5 years ago
|
||
Attachment #9061343 -
Attachment is obsolete: true
Attachment #9061369 -
Flags: review?(mkmelin+mozilla)
Comment 8•5 years ago
|
||
Comment on attachment 9061369 [details] [diff] [review] Bug-1545907_remove-grid-am-identity-edit.patch Review of attachment 9061369 [details] [diff] [review]: ----------------------------------------------------------------- Alright, r=mkmelin
Attachment #9061369 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/681a9ef10be9
remove grid usage from am-identity-edit.xul. r=mkmelin
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 69.0
You need to log in
before you can comment on or make changes to this bug.
Description
•