Closed Bug 1546279 Opened 6 years ago Closed 5 years ago

remove grid usage from comm/mailnews/base/prefs/content/am-main.xul

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(3 files, 1 obsolete file)

No description provided.
Assignee: nobody → khushil324
Type: defect → task
Attached patch Bug-1546279_remove-grid_am-main.patch (obsolete) (deleted) β€” β€” Splinter Review
Attachment #9061324 - Flags: review?(mkmelin+mozilla)
Attached image Screenshot 2019-04-29 at 4.16.32 PM.png (deleted) β€”

I guess what you are talking about in https://bugzilla.mozilla.org/show_bug.cgi?id=1545907#c2 is this dialogue box. I have corrected the behavior over here. You can check it.

Attachment #9061324 - Attachment is obsolete: true
Attachment #9061324 - Flags: review?(mkmelin+mozilla)
Attached patch Bug-1546279_remove-grid_am-main.patch (deleted) β€” β€” Splinter Review
Attachment #9061327 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9061327 [details] [diff] [review]
Bug-1546279_remove-grid_am-main.patch

Review of attachment 9061327 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin

::: mailnews/base/prefs/content/am-main.xul
@@ +41,5 @@
>        <description>&identityDesc.label;</description>
>        <separator class="thin"/>
> +      <hbox>
> +        <vbox>
> +          <hbox flex="1" align="center">

for these hboxes you can remove the align="center"
Attachment #9061327 - Flags: review?(mkmelin+mozilla) → review+

It does not look good without align="center". So we need this in this patch.

Status: NEW → ASSIGNED
Attached image Screenshot 2019-04-29 at 7.38.54 PM.png (deleted) β€”

It will look something like this without align=center.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9be27d28fd45
remove grid usage from am-main.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: