Closed
Bug 1546281
Opened 6 years ago
Closed 5 years ago
remove grid usage from comm/mailnews/base/prefs/content/am-server.xul
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
Updated•5 years ago
|
Type: defect → task
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Comment on attachment 9061394 [details] [diff] [review] Bug-1546281_remove-grid-am-server.patch Review of attachment 9061394 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/base/prefs/content/am-server.xul @@ +17,3 @@ > title="&serverSettings.label;" > onload="parent.onPanelLoaded('am-server.xul');"> > + <html:style> I think it would be better to put the css into a am-server.css file (next to the xul file)
Attachment #9061394 -
Flags: review?(mkmelin+mozilla) → feedback+
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #9061394 -
Attachment is obsolete: true
Attachment #9061649 -
Flags: review?(mkmelin+mozilla)
Comment 4•5 years ago
|
||
Comment on attachment 9061649 [details] [diff] [review] Bug-1546281_remove-grid-am-server.patch Review of attachment 9061649 [details] [diff] [review]: ----------------------------------------------------------------- r=mkmelin with the boilerplate added ::: mailnews/base/prefs/content/am-server.css @@ +1,1 @@ > +#amServerSetting { This file is missing the MPL boilerplace. Look at e.g. accountManage.css
Attachment #9061649 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 5•5 years ago
|
||
Attachment #9061649 -
Attachment is obsolete: true
Attachment #9062260 -
Flags: review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 68.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/17a0eac83bc5
remove grid usage from am-server.xul. r=mkmelin DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•