Digitally sign geckodriver binaries on Mac
Categories
(Testing :: geckodriver, enhancement, P2)
Tracking
(firefox70 verified)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | verified |
People
(Reporter: whimboo, Assigned: mozilla)
References
(Blocks 3 open bugs)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1427849 +++
Bug 1427849 got signing implemented for Linux and Windows, but bug 1470607 blocks us from doing the same on Mac. Johan will continue once that other bug got fixed.
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Comment 1•5 years ago
|
||
Johan, I would be interested to know when we could get this feature. Reason is that I want to get the new job created which collects all the geckodriver binaries and offers them as artifacts on a single job. I assume that as long as this bug hasn't been implemented, I will have to look for geckodriver-repack for MacOS instead. Later it should hopefully be easy to get this dependency flipped.
Hey Whimboo!
I'm sorry, I haven't worked closely from bug 1470607, deferring to Aki.
Regarding the dependencies: yeah, using geckodriver-repack for MacOS is the way to go, if you need a quick solution.
|
|
Reporter | |
Comment 3•5 years ago
|
||
(In reply to Johan Lorenzo [:jlorenzo] from comment #2)
Regarding the dependencies: yeah, using
geckodriver-repackfor MacOS is the way to go, if you need a quick solution.
Perfect. I will handle all that on bug 1558497.
I meant to NI :aki in comment 2.
|
Assignee | |
Comment 5•5 years ago
|
||
Hm. This is the first I’ve heard of this.
Mac notarization will hopefully roll out this week. Once that happens, we can add geckodriver signing to the mac build-signing tasks. (Do we need to sign localized versions or just the en-US?)
|
|
Reporter | |
Comment 6•5 years ago
|
||
Aki, that is great to hear! So we only have to sign one binary file here. There is no localization support for geckodriver. It's just English.
|
|
Reporter | |
Comment 7•5 years ago
|
||
Using the Apple Notary service for signed builds was actually done on bug 1471004, which seems to be rolled-out now.
Aki, would anyone be able to help us with the signing task? Thanks a lot.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 9•5 years ago
|
||
Also add the mac_geckodriver behavior, and remove the unused mac_pkg behavior.
|
|
Assignee | |
Comment 10•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 11•5 years ago
|
||
Updated the mac signing pool. Once we land the in-tree patch, we'll start signing geckodriver on mac.
|
|
Reporter | |
Comment 12•5 years ago
|
||
Thanks a lot for this quick patch Aki!
|
||
Comment 13•5 years ago
|
||
|
||
Comment 14•5 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 15•5 years ago
|
||
This looks great:
codesign --verify --verbose geckodriver
geckodriver: valid on disk
geckodriver: satisfies its Designated Requirement
Thanks a lot!
|
|
Reporter | |
Updated•5 years ago
|
Description
•