[de-xbl] convert the menu-button-base + menubutton.xml#menu-button bindings to custom element
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(3 files, 4 obsolete files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jorgk-bmo
:
review+
khushil324
:
review+
|
Details | Diff | Splinter Review |
Screenshot 2019-05-18 at 4.47.10 PM.png
The menu-button binding https://searchfox.org/comm-central/rev/024094c2ebc05723d2b0da86086539d5b97044cb/common/bindings/toolbar.xml#577 is hooked up here: https://searchfox.org/comm-central/rev/024094c2ebc05723d2b0da86086539d5b97044cb/mail/base/content/bindings.css#49
Bug 1538983 is converting the button binding (and button[type="menu"] binding) to custom element. The button-base binding which menu-button inherits from is going away in that conversion. See https://phabricator.services.mozilla.com/D27742
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
button-base isn't going away in bug 1546352 after all.
|
|
Assignee | |
Comment 2•6 years ago
|
||
But button-base was removed in bug 1538983. https://hg.mozilla.org/mozilla-central/rev/936c2d201405
|
|
Assignee | |
Comment 3•6 years ago
|
||
(And menu-button-base inherited from button-base. )
|
|
Assignee | |
Comment 4•6 years ago
|
||
Correction: button-base is still there, but will be removed "soon" in bug 1519577 after toolbarbutton is converted in bug 1519577.
|
|
Assignee | |
Comment 5•6 years ago
|
||
To add confusion here: the searchfox permalinks above are wrong since we actually have two bindings named menu-button: toolbar.xml#menu-button for <toolbarbutton> and menubutton.xml#menu-button for <button>
Let's have this bug for the menubutton.xml#menu-button work:
|
|
Assignee | |
Comment 9•5 years ago
|
||
This should be it, if bug 1551312 gets review. Test adjustments in bug 1547238.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 10•5 years ago
|
||
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
||
Comment 12•5 years ago
|
||
Comment on attachment 9065619 [details] [diff] [review] bug1546352_menubuttton_dexbl.patch Review of attachment 9065619 [details] [diff] [review]: ----------------------------------------------------------------- There is a linting error : 28:38 error 'MozXULElement' is not defined. no-undef (eslint) Also, On Mac, the button container has some padding and background color which is not similar to the trunk. I have attached the SS.
|
|
||
Comment 13•5 years ago
|
||
|
||
Comment 14•5 years ago
|
||
The "Folder Location" widget is also pretty much completely hosed. Will that be fixed here or do I need to fix another bug?
|
|
Assignee | |
Comment 16•5 years ago
|
||
For the visuals on mac, I can't really help. On linux it looks the same as it used to.
I wonder if adding the -moz-appearance: dualbutton; on mac could help: https://searchfox.org/comm-central/rev/95a184ce92612a12cb68ed2d7284a0c1c02cff30/mail/themes/linux/mail/messenger.css#810
I've fixed the linting error and unbitrotted.
|
|
Assignee | |
Comment 17•5 years ago
|
||
Lint issue fixed and unbitrotted.
Since you're on mac, maybe you can have a look at the styling problem?
I wonder if some style changes are required on windows.
|
||
Comment 19•5 years ago
|
||
This fixes the buttons on Mac and Windows.
|
|
||
Comment 20•5 years ago
|
||
Comment on attachment 9065910 [details] [diff] [review] bug1546352_menubuttton_dexbl.patch Review of attachment 9065910 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me with applying Richard's patch. r=khushil.
|
|
||
Comment 21•5 years ago
|
||
Comment on attachment 9065913 [details] [diff] [review] 1546352-fix-button-styling.patch Review of attachment 9065913 [details] [diff] [review]: ----------------------------------------------------------------- Looks good on Mac. r=khushil.
|
|
||
Comment 22•5 years ago
|
||
|
|
||
Comment 23•5 years ago
|
||
Comment on attachment 9065913 [details] [diff] [review] 1546352-fix-button-styling.patch Which buttons do I need to look at? The attachment reminder looks OK now, also the "New" button in the filter dialogue.
|
|
Assignee | |
Comment 24•5 years ago
|
||
I think those are the only ones. We have a bunch of <toolbarbutton type="menu-button"> but that is still xbl.
Thanks Richard!
|
||
Comment 27•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9331b129db1c
[de-xbl] convert the menu-button-base + menubutton.xml#menu-button bindings to custom element. r=khushil
https://hg.mozilla.org/comm-central/rev/96c877c4aba1
Fix the button styling on Mac and Windows. r=jorgk,khushil
|
|
||
Updated•5 years ago
|
Description
•