Closed Bug 1548094 Opened 5 years ago Closed 5 years ago

remove grid usage from comm/mailnews/extensions/newsblog/content/feed-subscriptions.xul

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → khushil324
Status: NEW → ASSIGNED
Attached patch Bug-1548094_remove-grid-feed-subscriptions.patch (obsolete) (deleted) β€” β€” Splinter Review
Attachment #9061733 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9061733 [details] [diff] [review]
Bug-1548094_remove-grid-feed-subscriptions.patch

Review of attachment 9061733 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/extensions/newsblog/content/feed-subscriptions.xul
@@ +102,5 @@
> +            </hbox>
> +          </vbox>
> +          <vbox flex="1">
> +            <textbox id="nameValue"
> +                     oninput="FeedSubscriptions.setPrefs(this)"/>

while touching this, you could add the missing ; for a bunch of these. Like FeedSubscriptions.setPrefs(this);
Attachment #9061733 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9061733 - Attachment is obsolete: true
Attachment #9062191 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/427525170a6c
remove grid usage from feed-subscriptions.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: