Closed
Bug 1548234
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/mailnews/base/search/content/CustomHeaders.xul
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
How to navigate to CustomHeaders.xul: Tools | Message Filters - then in the criteria choose to Customize.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #9061866 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Comment on attachment 9061866 [details] [diff] [review]
Bug-1548234_remove-grid-CustomHeaders.patch
Review of attachment 9061866 [details] [diff] [review]:
-----------------------------------------------------------------
Looks ok, r=mkmelin
::: mailnews/base/search/content/CustomHeaders.xul
@@ +33,5 @@
> flex="1"
> onselect="updateRemoveButton();" />
> + </vbox>
> + <vbox>
> + <label value=""/>
Slightly odd thing to do... but then again the input could be redesigned a bit and this wouldn't be an issue.
Attachment #9061866 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #9061866 -
Attachment is obsolete: true
Attachment #9062198 -
Flags: review+
Assignee | ||
Comment 4•5 years ago
|
||
I have updated the patch like this. Is this looks good?
Flags: needinfo?(mkmelin+mozilla)
Comment 5•5 years ago
|
||
I think the original looked better, so maybe we just go with that for now.
Flags: needinfo?(mkmelin+mozilla)
Updated•5 years ago
|
Attachment #9062199 -
Attachment is obsolete: true
Updated•5 years ago
|
Attachment #9062198 -
Attachment is obsolete: true
Updated•5 years ago
|
Attachment #9061866 -
Attachment is obsolete: false
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/98a9b8e62d9a
remove grid usage from CustomHeaders.xul. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•