Closed
Bug 1548235
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/mailnews/compose/content/sendProgress.xul
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #9061874 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Comment on attachment 9061874 [details] [diff] [review]
Bug-1548235_remove-grid-sendProgress.patch
Review of attachment 9061874 [details] [diff] [review]:
-----------------------------------------------------------------
::: mailnews/compose/content/sendProgress.xul
@@ +36,3 @@
> <label id="dialog.status" crop="center"/>
> + </hbox>
> + <hbox class="thin-separator" style="display:flex; align-items: stretch;">
For inline styles I'd use space between each specification, but no space inside, like
style="display:flex; align-items:stretch;">
@@ +40,3 @@
> <hbox pack="end">
> <label id="dialog.progressText"/>
> </hbox>
does look like complicated markup just to put the percentage after the progress bar
Attachment #9061874 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #9061874 -
Attachment is obsolete: true
Attachment #9062253 -
Flags: review?(mkmelin+mozilla)
Comment 4•5 years ago
|
||
Comment on attachment 9062253 [details] [diff] [review]
Bug-1548235_remove-grid-sendProgress.patch
Review of attachment 9062253 [details] [diff] [review]:
-----------------------------------------------------------------
I think it's almost correct, but there is some misalingnment.
I'm just calling window.openDialog("chrome://messenger/content/messengercompose/sendProgress.xul"); from the console. The progress bar is now thicker than it used to be, and aligned with bottom of the progress text
Attachment #9062253 -
Flags: review?(mkmelin+mozilla) → review-
Assignee | ||
Comment 5•5 years ago
|
||
Attachment #9062253 -
Attachment is obsolete: true
Attachment #9062952 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 6•5 years ago
|
||
Now, it is looking like this.
Comment 7•5 years ago
|
||
Comment on attachment 9062952 [details] [diff] [review]
Bug-1548235_de-grid-sendProgress.patch
Review of attachment 9062952 [details] [diff] [review]:
-----------------------------------------------------------------
r=mkmelin
Doesn't seem to show the problem in "real" usage
Attachment #9062952 -
Flags: review?(mkmelin+mozilla) → review+
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ee74021d18f5
remove grid usage from sendProgress.xul. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•