Convert the printing code from DocShellTree* to BrowsingContext
Categories
(Core :: Printing: Setup, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
(Whiteboard: [print2020_v75])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
M6 because printing support blocks enabling Fission in Nightly.
|
|
||
Comment 2•5 years ago
|
||
Jonathan, do you have an ETA for when you will be able to look at this bug?
IIUC, this bug blocks printing, so we'll need to fix it before enabling Fission Nightly (M6). Here are instructions for replacing nsIDocShellTreeItem with BrowsingContext:
https://wiki.mozilla.org/Project_Fission/DocShell_Tree_Replace
|
Assignee | |
Comment 3•5 years ago
|
||
Virtually all DocShellTree* uses have been removed from the printing code in various other printing refactoring bugs. I'll put up a patch for the rest shortly.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/fd383a15ed4e Convert the printing code to stop using DocShellTree* classes. r=farre
|
||
Comment 6•5 years ago
|
||
Backed out changeset fd383a15ed4e (bug 1552966) for causing browser_printpreview.js to permafail
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=281190611&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=fd383a15ed4e6a4570bc29765ed3dbc47616f1c0
backout: https://hg.mozilla.org/integration/autoland/rev/fa86e495e683df6a1b75b55233cbb293f7e74a60
|
|
||
Comment 7•5 years ago
|
||
This also permafails on the above push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=281191493&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=b26a70a0fe8f22ee4a5118c7c563ab98a115e692&searchStr=Windows%2C10%2Cx64%2Cdebug%2CWeb%2Cplatform%2Ctests%2Ctest-windows10-64%2Fdebug-web-platform-tests-e10s-5%2CW%28wpt5%29
|
||
Comment 8•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jwatt, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/33a086f16245 Convert the printing code to stop using DocShellTree* classes. r=farre
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
Description
•