Closed
Bug 1776296
Opened 2 years ago
Closed 2 years ago
Remove nsPrintJob's initialization code around mIsForModalWindow, per its reference to (closed) bug 1558907
Categories
(Core :: Printing: Output, task)
Core
Printing: Output
Tracking
()
RESOLVED
FIXED
107 Branch
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: dholbert, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
I noticed this block of code in our nsPrintJob initialization code:
if (nsPIDOMWindowOuter* window = aOriginalDoc->GetWindow()) {
if (nsCOMPtr<nsIWebBrowserChrome> wbc = window->GetWebBrowserChrome()) {
// We only get this in order to skip opening the progress dialog when
// the window is modal. Once the platform code stops opening the
// progress dialog (bug 1558907), we can get rid of this.
wbc->IsWindowModal(&mIsForModalWindow);
}
The comment there refers to bug 1558907, which is now WORKSFORME ("Obsoleted by bug 1745452" per bug 1558907 comment 5).
jwatt, should we take action on this^ code-comment and do some cleanup/simplification here?
Flags: needinfo?(jwatt)
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/cd492741a061
Remove nsPrintJob::mIsForModalWindow. r=dholbert
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox107:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•