Closed Bug 1776296 Opened 2 years ago Closed 2 years ago

Remove nsPrintJob's initialization code around mIsForModalWindow, per its reference to (closed) bug 1558907

Categories

(Core :: Printing: Output, task)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: dholbert, Assigned: jwatt)

References

Details

Attachments

(1 file)

I noticed this block of code in our nsPrintJob initialization code:

https://searchfox.org/mozilla-central/rev/45ecfdfaa2f74083b11c1414ddb4c1a640b0d19d/layout/printing/nsPrintJob.cpp#278-284

if (nsPIDOMWindowOuter* window = aOriginalDoc->GetWindow()) {
  if (nsCOMPtr<nsIWebBrowserChrome> wbc = window->GetWebBrowserChrome()) {
    // We only get this in order to skip opening the progress dialog when
    // the window is modal.  Once the platform code stops opening the
    // progress dialog (bug 1558907), we can get rid of this.
    wbc->IsWindowModal(&mIsForModalWindow);
  }

The comment there refers to bug 1558907, which is now WORKSFORME ("Obsoleted by bug 1745452" per bug 1558907 comment 5).

jwatt, should we take action on this^ code-comment and do some cleanup/simplification here?

Flags: needinfo?(jwatt)
Assignee: nobody → jwatt
Status: NEW → ASSIGNED

Thanks, Daniel.

Flags: needinfo?(jwatt)
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/cd492741a061 Remove nsPrintJob::mIsForModalWindow. r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: