Closed Bug 1553202 Opened 5 years ago Closed 5 years ago

Incorrect use of WebExtensionPolicy.readyPromise in SearchService.jsm

Categories

(Firefox :: Search, task)

Product:
Firefox
Component:
Search
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1552559

People

(Reporter: robwu, Assigned: daleharvey)

References

(Regression)

Details

(Keywords: regression)

In a patch to bug 1544273, the following code was introduced at https://searchfox.org/mozilla-central/rev/a887c90ea9c19a0b5529a1f5fa351929944887ba/toolkit/components/search/SearchService.jsm#915

    await WebExtensionPolicy.readyPromise;

This code does nothing. readyPromise is not a static member, but a member of a WebExtensionPolicy member, and documented at https://searchfox.org/mozilla-central/rev/a887c90ea9c19a0b5529a1f5fa351929944887ba/dom/chrome-webidl/WebExtensionPolicy.webidl#190-202 . If you only have an ID, then you can obtain a reference to such an object via WebExtensionPolicy.getByID(addonId) .

This line should be replaced with something more appropriate, or be removed.

Flags: needinfo?(dharvey)

Yeh looking at this in https://bugzilla.mozilla.org/show_bug.cgi?id=1552559

Assignee: nobody → dharvey
Flags: needinfo?(dharvey)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.