Closed
Bug 1553768
Opened 5 years ago
Closed 5 years ago
[de-xbl] remove the menu-vertical, appmenu-vertical bindings - convert to <toolbarbutton is="toolbarbutton-appmenu">
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
Bug 1546309 will remain for splitmenu and general rework of the appmenu, but we need to fix the actual appmenu button now since bug 1519577 is landing.
This bug will remove the menu-vertical, appmenu-vertical bindings and convert it to <toolbarbutton is="toolbarbutton-appmenu">.
The patch applies on top of bug 1547233.
Assignee | ||
Comment 1•5 years ago
|
||
On top of the patch in bug 1547233 (refreshing that in a minute)
Attachment #9066986 -
Flags: review?(alessandro)
Assignee | ||
Comment 2•5 years ago
|
||
Including the added file
Attachment #9066986 -
Attachment is obsolete: true
Attachment #9066986 -
Flags: review?(alessandro)
Attachment #9066995 -
Flags: review?(khushil324)
Attachment #9066995 -
Flags: review?(alessandro)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/42690276c3c0
[de-xbl] remove the menu-vertical, appmenu-vertical bindings - convert to <toolbarbutton is="toolbarbutton-appmenu">. rs=bustage-fix,jorgk
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 69.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/30859b715661
Follow-up: fix linting error. r=me
Comment 5•5 years ago
|
||
Comment on attachment 9066995 [details] [diff] [review]
bug1553768_appmenu-dexbl.patch
Review of attachment 9066995 [details] [diff] [review]:
-----------------------------------------------------------------
Other than that really minor indentation style, LGTM.
r=aleca
::: mail/base/content/toolbarbutton-appmenu.js
@@ +48,5 @@
> + }
> + }
> + customElements.define("toolbarbutton-appmenu",
> + MozToolbarButtonAppmenu, { extends: "toolbarbutton" }
> + );
nit: this seems like a strange indentation style we don't use anywhere else.
Attachment #9066995 -
Flags: review?(alessandro) → review+
Updated•5 years ago
|
Attachment #9066995 -
Flags: review?(khushil324)
You need to log in
before you can comment on or make changes to this bug.
Description
•